Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0312E11C13 for ; Thu, 22 May 2014 09:03:40 +0000 (UTC) Received: (qmail 33879 invoked by uid 500); 22 May 2014 09:03:39 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 33852 invoked by uid 500); 22 May 2014 09:03:39 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 33845 invoked by uid 500); 22 May 2014 09:03:39 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 33842 invoked by uid 99); 22 May 2014 09:03:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 May 2014 09:03:39 +0000 Date: Thu, 22 May 2014 09:03:39 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-6740) Direct agent command throttling improvements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005746#comment-14005746 ] ASF subversion and git services commented on CLOUDSTACK-6740: ------------------------------------------------------------- Commit d5754d910112aed4ce482cffd04892683c7029db in cloudstack's branch refs/heads/master from [~koushikd] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d5754d9 ] CLOUDSTACK-6740: Direct agent command throttling improvements List of changes: 1. Created a separate thread pool for handling cron and ping tasks. The size of the pool is based on direct.agent.pool.size. The existing direct agent pool will run all commands other than cron and ping. 2. For normal tasks (generated as part of user/admin API calls), if throttle limit is reached then tasks get queued up for subsequent execution once threads are available. 3. For cron and ping tasks (internally generated by MS like ping, VM sync etc.), if throttle limit is reached then these gets rejected. Since these are internally generated these can be rejected without any issues. > Direct agent command throttling improvements > -------------------------------------------- > > Key: CLOUDSTACK-6740 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6740 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Affects Versions: 4.4.0 > Reporter: Koushik Das > Assignee: Koushik Das > Fix For: 4.5.0 > > > List of changes: > 1. Create a separate thread pool for handling cron tasks. Currently normal and cron tasks are all handled by the same direct agent thread pool. > 2. For normal tasks (generated as part of user/admin API calls), if throttle limit reached then tasks will be queued up for subsequent execution. This will avoid uncertainty as to when a certain command pass/fail based on the throttling. For now the queue is unbounded but this needs to be revisited. One possibility is to change the agent state to something appropriate, based on the queue limit, so that commands are not sent to this host from the upper layers of MS. > 3. For cron tasks (internally generated by MS like ping, VM sync etc.), if throttle limit reached then it will be rejected. Since these are internally generated these can be rejected without any issues. -- This message was sent by Atlassian JIRA (v6.2#6252)