cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Koushik Das (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CLOUDSTACK-6579) used_bytes column of storage_pool table is no longer used and should be removed
Date Sat, 10 May 2014 22:05:15 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Koushik Das resolved CLOUDSTACK-6579.
-------------------------------------

    Resolution: Fixed

> used_bytes column of storage_pool table is no longer used and should be removed
> -------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-6579
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6579
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.4.0
>            Reporter: Mike Tutkowski
>            Assignee: Koushik Das
>             Fix For: 4.5.0
>
>
> From an e-mail discussion on the mailing list:
> Ideally, we should deprecate the column since its not used and causes
> confusion.
> Setting to this value wouldn't help because this column is never updated
> regularly.
> On 05/05/14 10:28 AM, "Mike Tutkowski" <mike.tutkowski@solidfire.com>
> wrote:
> >How's about I just check this code into master?
> >
> >poolVO.setUsedBytes(mspAnswer.getPoolInfo().getCapacityBytes() -
> >mspAnswer.getPoolInfo().getAvailableBytes());
> >
> >It is patterned off of the PrimaryDataStoreHelper.attachHost logic, which
> >looks like this:
> >
> >pool.setUsedBytes(existingInfo.getCapacityBytes() -
> >existingInfo.getAvailableBytes());
> >
> >
> >On Mon, May 5, 2014 at 10:21 AM, Nitin Mehta <Nitin.Mehta@citrix.com>
> >wrote:
> >
> >> This column is not used for calculating capacity for pool.
> >> We have always used op host capacity table. Nevertheless please do file
> >>a
> >> bug
> >>
> >> Thanks,
> >> -Nitin
> >> ________________________________________
> >> From: Mike Tutkowski [mike.tutkowski@solidfire.com]
> >> Sent: Monday, May 05, 2014 9:12 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: How is this working?
> >>
> >> My storage plug-in actually uses a custom host listener, so I have not
> >> encountered this issue.
> >>
> >> I don't remember off hand if it was in 4.2 or 4.3, but at some point
> >> someone changed the storage_pool table's available_bytes column to be
> >> used_bytes.
> >>
> >> It looks like this code you reference was missed.
> >>
> >>
> >> On Mon, May 5, 2014 at 4:35 AM, Koushik Das <koushik.das@citrix.com>
> >> wrote:
> >>
> >> > I came across this code snippet in hostConnect() method in
> >> > DefaultHostListener.java. Look at the line where the used bytes is
> >>set on
> >> > the poolVO. This looks like a serious bug. Looking at the history this
> >> code
> >> > has been there since a year. Has anyone encountered any issues with
> >> primary
> >> > storage capacity?
> >> >
> >> > ModifyStoragePoolAnswer mspAnswer = (ModifyStoragePoolAnswer)answer;
> >> > Š..
> >> > StoragePoolVO poolVO = this.primaryStoreDao.findById(poolId);
> >> > poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
> >> > poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
> >> > primaryStoreDao.update(pool.getId(), poolVO);
> >> >
> >> >
> >> > -Koushik



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message