cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-6088) template validation patch (4.2) needs to be rebased for master
Date Wed, 28 May 2014 21:49:02 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011654#comment-14011654
] 

ASF subversion and git services commented on CLOUDSTACK-6088:
-------------------------------------------------------------

Commit 15ac47e47b4c9a2323888d73f6988cb967647e28 in cloudstack's branch refs/heads/master from
[~mlsorensen]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=15ac47e ]

CLOUDSTACK-6088: Check first bytes of template when downloading to verify format/type


> template validation patch (4.2) needs to be rebased for master
> --------------------------------------------------------------
>
>                 Key: CLOUDSTACK-6088
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6088
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: Future
>            Reporter: Marcus Sorensen
>            Assignee: Laszlo Hornyak
>             Fix For: Future
>
>         Attachments: template-content-validation-v2.patch
>
>
> Submitting this 4.2 patch that validates template contents upon initial download, such
that a qcow2 can't be named '.img', or a .vmdk descriptor file (which is text) can't be successfully
uploaded as a template.
> It needs to be rebased/integrated into master, and perhaps some more testing to verify
that it correctly catches all template types.
> For bonus points, we can use TemplateUtils.isCorrectExtension to clean up a lot of the
code that verifies extensions, look for "qcow2.gz" in HypervisorTemplateAdaptor and VolumeManagerImpl
(or their master equivalents)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message