Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DE71310F47 for ; Tue, 11 Mar 2014 23:15:56 +0000 (UTC) Received: (qmail 90092 invoked by uid 500); 11 Mar 2014 23:15:53 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 90070 invoked by uid 500); 11 Mar 2014 23:15:53 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 90038 invoked by uid 500); 11 Mar 2014 23:15:52 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 89990 invoked by uid 99); 11 Mar 2014 23:15:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Mar 2014 23:15:50 +0000 Date: Tue, 11 Mar 2014 23:15:50 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-5986) dnsmasq racy condition result in dnsmasq failed to handout IP address MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931126#comment-13931126 ] ASF subversion and git services commented on CLOUDSTACK-5986: ------------------------------------------------------------- Commit 8937434fce6958155e9871caa1648504b7c34999 in cloudstack's branch refs/heads/master from [~yasker] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8937434 ] CLOUDSTACK-5986: Fix dnsmasq lease for VPC > dnsmasq racy condition result in dnsmasq failed to handout IP address > --------------------------------------------------------------------- > > Key: CLOUDSTACK-5986 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5986 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Virtual Router > Affects Versions: 4.2.0, 4.2.1 > Reporter: Sheng Yang > Assignee: Sheng Yang > Priority: Critical > Fix For: 4.2.1, 4.3.0 > > > In the past, dnsmasq.leases is managed by cloudstack, and would be updated after new entry is added(and the entry with same IP or host would be removed). > In 4.2, we introduced dhcp_release try to speed up the dnsmasq reload process, thus result in this issue. > So in this scenario: > 1. VM1 would create entry: "mac A, IP A, host A" > 2. VM2 would create entry: "mac B, IP B, host B" > 3. VM1 destroyed and VM 2 destroyed, no change to lease file, two records still existed. > 4. VM1 created with IP B: "mac C, IP B, host A". > At this time, lease file would only contain: "mac C, IP B, host A", because the original entries would be removed by either IP match or host name match. > In fact dnsmasq still holds lease of IP A with mac A in memory, but record is already removed from lease file by cloudstack. The lease file is out of sync now. > 5. VM2 recreated with IP A, dhcp_release would be used to release the lease. But there is no "mac A, IP A" record in the lease file, so dhcp_release failed. > So result in dnsmasq cannot handle out the IP A to new mac D, because dnsmasq was still holding lease for IP A with mac A and haven't been released yet. > So it only happened when user create and destroy different VMs which share the same name but get different IPs. -- This message was sent by Atlassian JIRA (v6.2#6252)