cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CLOUDSTACK-6129) Script names are hard-coded into some init scripts
Date Mon, 10 Mar 2014 21:26:43 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926240#comment-13926240
] 

Marcus Sorensen edited comment on CLOUDSTACK-6129 at 3/10/14 9:25 PM:
----------------------------------------------------------------------

changing to 'basename $0' per CLOUDSTACK-6220...


was (Author: mlsorensen):
changing to 'basename $0' per CLOUDSTACK-6181...

> Script names are hard-coded into some init scripts
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-6129
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6129
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Install and Setup
>            Reporter: John Kinsella
>            Assignee: John Kinsella
>             Fix For: 4.4.0
>
>
> Some of the init scripts which ACS installs have the script name hard-coded into it.
An example from python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in:
>     whatami=cloud-external-ipallocator
>     ...
>     echo $"Usage: $whatami {start|stop|restart|status|help}"
> This is bad practice, $0 should be used to get a script's name, otherwise - as shown
in this example - things will fail or folks will be confused.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message