From issues-return-38794-apmail-cloudstack-issues-archive=cloudstack.apache.org@cloudstack.apache.org Mon Feb 10 05:00:23 2014 Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 86B6F10FA1 for ; Mon, 10 Feb 2014 05:00:23 +0000 (UTC) Received: (qmail 68776 invoked by uid 500); 10 Feb 2014 05:00:23 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 68569 invoked by uid 500); 10 Feb 2014 05:00:22 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 68536 invoked by uid 500); 10 Feb 2014 05:00:21 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 68525 invoked by uid 99); 10 Feb 2014 05:00:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Feb 2014 05:00:20 +0000 Date: Mon, 10 Feb 2014 05:00:20 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-6053) While adding smb as primary or secondary the password should be uri encoded MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896215#comment-13896215 ] ASF subversion and git services commented on CLOUDSTACK-6053: ------------------------------------------------------------- Commit 306ffa02183ab1a35f2a004016c0f1159e7dfb23 in branch refs/heads/master from [~devdeep] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=306ffa0 ] CLOUDSTACK-6053: While adding a primary or secondary of type smb the password wasn't encoded. This cause createStoragePool or addImageStore command to fail if special characters were present. Updated the code to pass user, password and domain as part of details while adding primary or secondary. Also made changes on server side to handle it. > While adding smb as primary or secondary the password should be uri encoded > --------------------------------------------------------------------------- > > Key: CLOUDSTACK-6053 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6053 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Affects Versions: 4.3.0 > Reporter: Devdeep Singh > Assignee: Devdeep Singh > Fix For: 4.3.0 > > > When a smb share is added as a primary or secondary the user, password and domain are passed in the url. If the password has special characters (like &) added the share fails as the server isn't able to parse the uri. > User, password and details should be passed as details parameters in the api and the server side should be updated to understand it. -- This message was sent by Atlassian JIRA (v6.1.5#6160)