cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-6160) [Marvin]: Remove references for apiclient.hypervisor
Date Mon, 24 Feb 2014 13:29:19 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910292#comment-13910292
] 

ASF subversion and git services commented on CLOUDSTACK-6160:
-------------------------------------------------------------

Commit bf77e9d66931468e785ca48222a564abf557fad7 in cloudstack's branch refs/heads/marvin from
[~santhoshe]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bf77e9d ]

CLOUDSTACK-6160: Changes to marvin apiclient

Removed apiclient.hypervisor references. More details in the bug
Few other changes pending for this related to VirtualMachine.create
need to be cleaned up


> [Marvin]: Remove references for apiclient.hypervisor
> ----------------------------------------------------
>
>                 Key: CLOUDSTACK-6160
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6160
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation, marvin
>            Reporter: Santhosh Kumar Edukulla
>            Assignee: Santhosh Kumar Edukulla
>
> Currently, we receive hypervisor information from cfg file and set it to apiclient under
test client, ideally apiclient's responsibility is not to deal with hypervisor information.
apiclient is a reference to cloudstackAPI interface. 
> We are setting hypervisor information to apiclient under testclient and are using at
various palces. This is wrong approach.
> TestClient should be abstracted entity to tests and configuration passed to test run.
All the tests using testclient should use information passed by users including hypervisor
information but not the apiclient.
>  
> Even apiclient is part of TestClient,  testclient should handle hypervisor information
passed through cfg to delegate this information to tests.
> So, removed references of apiclient.hypervisor and added a new method getHypervisorInfo
to cloudstackTestClient to retrieve  hypervisor information. Test users can then use this
method to retrieve hypervisor information for tests instead of current usage apiclient.hypervisor.
> With this, apiclient responsibility of passing hypervisor information is decoupled and
removed.
> Note : we have self.config available which we are setting as an attribute to TestCase,
which has the hypervisor information available, ideally the config passed should also be abstracted
through test client only , not inject to test case.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message