Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 297AB107FF for ; Thu, 23 Jan 2014 13:09:42 +0000 (UTC) Received: (qmail 42388 invoked by uid 500); 23 Jan 2014 13:09:41 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 42174 invoked by uid 500); 23 Jan 2014 13:09:40 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 42143 invoked by uid 500); 23 Jan 2014 13:09:39 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 42138 invoked by uid 99); 23 Jan 2014 13:09:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jan 2014 13:09:38 +0000 Date: Thu, 23 Jan 2014 13:09:38 +0000 (UTC) From: "Wei Zhou (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-5810) addIpToNic: the owner of the secondary ip should be derived from vmInstance object, not from the caller account MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879909#comment-13879909 ] Wei Zhou commented on CLOUDSTACK-5810: -------------------------------------- Alena, Jayapal, Could you change these patches for 4.3.0 ? Thanks! -Wei > addIpToNic: the owner of the secondary ip should be derived from vmInstance object, not from the caller account > --------------------------------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-5810 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5810 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Affects Versions: 4.3.0 > Reporter: Alena Prokharchyk > Assignee: Jayapal Reddy > Priority: Critical > Fix For: 4.4.0 > > > Steps to reproduce: > ==================== > 1) Deploy a vm as a regular user account. > 2) Login as admin, add secondary ip to the user's vm's nic. > Bug: the secondary ip account owner is set to Admin account. This is wrong, as in CS we never let link objects belonging to diff accounts, unless its a public resource (template, network). In cases like this one, the owner info should be derived from the vm instance object. > Jayapal, I will fix the API, and you have to fix the DB upgrade part. The fix should be: compare the sec ips accounts with the account of corresponding vms, and update nic_secondary_ips if account info is different. Should be done as a part of 43-44 upgrade. -- This message was sent by Atlassian JIRA (v6.1.5#6160)