Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6146B10795 for ; Mon, 16 Dec 2013 12:42:17 +0000 (UTC) Received: (qmail 65004 invoked by uid 500); 16 Dec 2013 12:42:13 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 64977 invoked by uid 500); 16 Dec 2013 12:42:11 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 64919 invoked by uid 500); 16 Dec 2013 12:42:08 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 64904 invoked by uid 99); 16 Dec 2013 12:42:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Dec 2013 12:42:08 +0000 Date: Mon, 16 Dec 2013 12:42:08 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-5145) ListNetworkACL API should list ACLs owned by the user only MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849112#comment-13849112 ] ASF subversion and git services commented on CLOUDSTACK-5145: ------------------------------------------------------------- Commit e2805b802cb7eb82bf885199e0bd289bcb599167 in branch refs/heads/4.3 from [~kishan] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e2805b8 ] CLOUDSTACK-5145 : Added permission checks while deleting network ACLs > ListNetworkACL API should list ACLs owned by the user only > ---------------------------------------------------------- > > Key: CLOUDSTACK-5145 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5145 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Kishan Kavala > Assignee: Kishan Kavala > Priority: Blocker > Fix For: 4.2.1, 4.3.0 > > > ListNetworkACL API should filter ACLs by caller and list ACLs which can be accessed by the user only. > If API call is not called with a networkid or other filter, every ACL in the system is dumped, which is both a performance issue and a security issue. If a networkid is provided, but the network doesn't have an ACL list or any ACL items attached, the same issue occurs. > Likewise, listNetworkACLLists gives access to see non-owned lists, which in turn gives vpc ids for non-owned resources. > Example: > 1. Set up a zone > 2. Create a VPC or network as admin > 3. Create an ACL list for the network > 4. Create a new domain and unprivileged user > 5. Generate API keys for user > 6. Issue a 'listNetworkACLs' API call. You should see the ACL list items from the admin-owned list > 7. Issue a 'listNetworkACLLists' API call referencing aclid from non-owned acl item. You should see the acl list info and which vpc it belongs to. > 8. Listing the vpc attached to the acl list properly stops with an 'unauthorized' response as step 7 above should. -- This message was sent by Atlassian JIRA (v6.1.4#6159)