cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CLOUDSTACK-5512) template format name checking is crude and doesn't work with advanced URLs
Date Mon, 16 Dec 2013 04:51:09 GMT
Marcus Sorensen created CLOUDSTACK-5512:
-------------------------------------------

             Summary: template format name checking is crude and doesn't work with advanced
URLs
                 Key: CLOUDSTACK-5512
                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5512
             Project: CloudStack
          Issue Type: Bug
      Security Level: Public (Anyone can view this level - this is the default.)
    Affects Versions: 4.2.0, 4.1.0, 4.0.0
            Reporter: Marcus Sorensen
             Fix For: Future, 4.3.0


Template name checking currently just looks at the very end of the url string. e.g.:

private void checkFormat(String format, String url) {
        if((!url.toLowerCase().endsWith("vhd"))

This breaks functionality such as registering a template via an S3 pre-signed URL, or anything
where the file extension is not the last part of the URL. We should at least attempt to parse
the URL for filename vs parameters.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message