cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alena Prokharchyk (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CLOUDSTACK-5318) createNetworkACL command doesnt fails on vpc non upgraded router
Date Tue, 10 Dec 2013 18:02:07 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alena Prokharchyk resolved CLOUDSTACK-5318.
-------------------------------------------

    Resolution: Won't Fix

VR version check shouldn't be a part of CS business logic. When upgraded VR doesn't support
some command, the backend script fails, and the error returns to the CS management server.

In this particular case there are no changes in the upgraded routers preventing network's
nic plug. 

As admin gets notified during the upgrade that VR's need to be upgraded, so we rely on the
fact that VR's will be upgraded as a part of the cloud upgrade. And we are not gonna provide
a check in the business logic layer to ensure that.

> createNetworkACL command doesnt fails on vpc non upgraded router
> ----------------------------------------------------------------
>
>                 Key: CLOUDSTACK-5318
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5318
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Upgrade, Virtual Router
>    Affects Versions: 4.3.0
>            Reporter: shweta agarwal
>            Assignee: Alena Prokharchyk
>            Priority: Critical
>             Fix For: 4.3.0
>
>
> Repro steps:
> 1. On 3.0.7 setup create a VPC network
> 2. upgrade to 4.3
> 3.Create network ACL on vpc network when router is not upgraded
> Bug:
> Create network ACL command will succeed
> Exception :
> Create network ACLcommand should fail sating router needs upgrade:
> MS log shows : 
> 013-11-29 16:38:44,893 DEBUG [c.c.a.ApiServlet] (catalina-exec-15:ctx-8254338a) ===START===
 10.146.0.132 -- GET  command=createNetworkACLList&vpcid=0527de8e-1071-45d9-b204-7c15cf9b5db7&response=json&sessionkey=CNU%2FUxmL5sTxIFWo8PSATnLucYk%3D&name=aaaaaaaaaaaaaaa&description=aaaaaaaaaaaaaa&_=1385723344873
> 2013-11-29 16:38:45,034 DEBUG [c.c.a.m.DirectAgentAttache] (DirectAgent-195:ctx-062673cc)
Seq 1-1005072966: Response Received:
> 2013-11-29 16:38:45,035 DEBUG [c.c.a.t.Request] (StatsCollector-3:ctx-fcc5f91e) Seq 1-1005072966:
Received:  { Ans: , MgmtId: 233845177509765, via: 1, Ver: v1, Flags: 10, { GetStorageStatsAnswer
} }
> 2013-11-29 16:38:45,037 DEBUG [c.c.a.m.DirectAgentAttache] (DirectAgent-328:ctx-c0dc0c04)
Seq 5-1023817202: Executing request
> 2013-11-29 16:38:45,154 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (catalina-exec-15:ctx-8254338a
ctx-1f4e92f9) submit async job-145, details: AsyncJobVO {id:145, userId: 2, accountId: 2,
instanceType: None, instanceId: 8, cmd: org.apache.cloudstack.api.command.user.network.CreateNetworkACLListCmd,
cmdInfo: {"id":"8","response":"json","sessionkey":"CNU/UxmL5sTxIFWo8PSATnLucYk\u003d","cmdEventType":"NETWORK.ACL.CREATE","ctxUserId":"2","description":"aaaaaaaaaaaaaa","name":"aaaaaaaaaaaaaaa","httpmethod":"GET","_":"1385723344873","ctxAccountId":"2","vpcid":"0527de8e-1071-45d9-b204-7c15cf9b5db7","ctxStartEventId":"513"},
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid:
233845177509765, completeMsid: null, lastUpdated: null, lastPolled: null, created: null}
> 2013-11-29 16:38:45,155 INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-43:ctx-6abcb246)
Add job-145 into job monitoring
> 2013-11-29 16:38:45,155 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (Job-Executor-43:ctx-6abcb246)
Executing AsyncJobVO {id:145, userId: 2, accountId: 2, instanceType: None, instanceId: 8,
cmd: org.apache.cloudstack.api.command.user.network.CreateNetworkACLListCmd, cmdInfo: {"id":"8","response":"json","sessionkey":"CNU/UxmL5sTxIFWo8PSATnLucYk\u003d","cmdEventType":"NETWORK.ACL.CREATE","ctxUserId":"2","description":"aaaaaaaaaaaaaa","name":"aaaaaaaaaaaaaaa","httpmethod":"GET","_":"1385723344873","ctxAccountId":"2","vpcid":"0527de8e-1071-45d9-b204-7c15cf9b5db7","ctxStartEventId":"513"},
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid:
233845177509765, completeMsid: null, lastUpdated: null, lastPolled: null, created: null}
> 2013-11-29 16:38:45,155 DEBUG [c.c.a.ApiServlet] (catalina-exec-15:ctx-8254338a ctx-1f4e92f9)
===END===  10.146.0.132 -- GET  command=createNetworkACLList&vpcid=0527de8e-1071-45d9-b204-7c15cf9b5db7&response=json&sessionkey=CNU%2FUxmL5sTxIFWo8PSATnLucYk%3D&name=aaaaaaaaaaaaaaa&description=aaaaaaaaaaaaaa&_=1385723344873
> 2013-11-29 16:38:45,163 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (Job-Executor-43:ctx-6abcb246
ctx-1f4e92f9) Complete async job-145, jobStatus: SUCCEEDED, resultCode: 0, result: org.apache.cloudstack.api.response.NetworkACLResponse/networkacllist/{"id":"37525927-26e7-44aa-94ce-cfd783c9e303","name":"aaaaaaaaaaaaaaa","description":"aaaaaaaaaaaaaa","vpcid":"0527de8e-1071-45d9-b204-7c15cf9b5db7"}
> 2013-11-29 16:38:45,245 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (Job-Executor-43:ctx-6abcb246)
Done executing org.apache.cloudstack.api.command.user.network.CreateNetworkACLListCmd for
job-145
> 2013-11-29 16:38:45,278 INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-43:ctx-6abcb246)
Remove job-145 from job monitoring
> DB shows vpc id router not upgraded
> "id" "element_id" "public_mac_address" "public_ip_address" "public_netmask" "guest_netmask"
"guest_ip_address" "is_redundant_router" "priority" "is_priority_bumpup" "redundant_state"
"stop_pending" "role" "template_version" "scripts_version" "vpc_id"
> "11" "2" "06:98:6e:00:00:2c" "10.147.51.13" "255.255.255.0" "" "" "0" "0" "0" "UNKNOWN"
"0" "VIRTUAL_ROUTER" "Cloudstack Release 3.0 Mon Feb 6 15:10:04 PST 2012" "973c0565a2fe991f0903902588d4d52e"
"1"
> "12" "2" "06:8f:e4:00:00:39" "10.147.51.26" "255.255.255.0" "" "" "0" "0" "0" "UNKNOWN"
"0" "VIRTUAL_ROUTER" "Cloudstack Release 3.0 Mon Feb 6 15:10:04 PST 2012" "973c0565a2fe991f0903902588d4d52e"
"2"
> "13" "2" "06:b0:ee:00:00:78" "10.147.51.89" "255.255.255.0" "" "" "0" "0" "0" "UNKNOWN"
"0" "VIRTUAL_ROUTER" "Cloudstack Release 3.0 Mon Feb 6 15:10:04 PST 2012" "973c0565a2fe991f0903902588d4d52e"
"3"
> "14" "2" "06:85:fc:00:00:2b" "10.147.51.12" "255.255.255.0" "" "" "0" "0" "0" "UNKNOWN"
"0" "VIRTUAL_ROUTER" "Cloudstack Release 3.0 Mon Feb 6 15:10:04 PST 2012" "973c0565a2fe991f0903902588d4d52e"
"4" 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message