Return-Path: 
 <issues-return-31790-apmail-cloudstack-issues-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-issues-archive@www.apache.org
Delivered-To: apmail-cloudstack-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7118B103F1
	for <apmail-cloudstack-issues-archive@www.apache.org>;
 Tue, 12 Nov 2013 02:16:20 +0000 (UTC)
Received: (qmail 84345 invoked by uid 500); 12 Nov 2013 02:16:18 -0000
Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org
Received: (qmail 84321 invoked by uid 500); 12 Nov 2013 02:16:18 -0000
Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:issues@cloudstack.apache.org>
List-Id: <issues.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list issues@cloudstack.apache.org
Received: (qmail 84280 invoked by uid 500); 12 Nov 2013 02:16:18 -0000
Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org
Received: (qmail 84216 invoked by uid 99); 12 Nov 2013 02:16:18 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Nov 2013 02:16:18 +0000
Date: Tue, 12 Nov 2013 02:16:18 +0000 (UTC)
From: "Prachi Damle (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12678717.1384222088785.55611.1384222578604@arcas>
In-Reply-To: <JIRA.12678717.1384222088785@arcas>
References: <JIRA.12678717.1384222088785@arcas>
Subject: [jira] [Resolved] (CLOUDSTACK-5140) A stopped vm cant start after
 disable threshold has been reached on the storage pool
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/CLOUDSTACK-5140?page=3Dcom.atl=
assian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prachi Damle resolved CLOUDSTACK-5140.
--------------------------------------

    Resolution: Fixed

> A stopped vm cant start after disable threshold has been reached on the s=
torage pool
> -------------------------------------------------------------------------=
-----------
>
>                 Key: CLOUDSTACK-5140
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-514=
0
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: Management Server
>    Affects Versions: 4.2.0
>            Reporter: Prachi Damle
>            Assignee: Prachi Damle
>             Fix For: 4.2.1
>
>
> Incorrect primary storage allocation behaviour:
> If a datastore reaches =E2=80=98disable threshold=E2=80=99 a stopped VM t=
hat was already on that datastore will refuse to start? Pre 4.2 thresholds =
were only applicable at the allocation time.=20
> I still see the code is present in 4.2 and master as well that can cause =
this issue.
> Following highlighted code is what causes it:
> DeploymentPlanningMgrImpl :: findPotentialDeploymentResources () {
> =E2=80=A6.
> if (hostCanAccessSPool(potentialHost, potentialSPool)) {
> hostCanAccessPool =3D true;
> if (multipleVolume)
> { List<Volume> requestVolumes =3D null; if (volumeAllocationMap.containsK=
ey(potentialSPool)) requestVolumes =3D volumeAllocationMap.get(potentialSPo=
ol); else requestVolumes =3D new ArrayList<Volume>(); requestVolumes.add(vo=
l); if (!_storageMgr.storagePoolHasEnoughSpace(requestVolumes, potentialSPo=
ol)) continue; volumeAllocationMap.put(potentialSPool, requestVolumes); }
> storage.put(vol, potentialSPool);
> haveEnoughSpace =3D true;
> break;
> }
> =E2=80=A6
> }
> Issue is that this check should NOT be done for a Volume that is already =
created and exists on the pool.
> Happens with a VM having root and data volumes.



--
This message was sent by Atlassian JIRA
(v6.1#6144)