Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3255C102D7 for ; Wed, 6 Nov 2013 11:44:28 +0000 (UTC) Received: (qmail 3116 invoked by uid 500); 6 Nov 2013 11:44:26 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 2919 invoked by uid 500); 6 Nov 2013 11:44:20 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 2911 invoked by uid 500); 6 Nov 2013 11:44:19 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 2907 invoked by uid 99); 6 Nov 2013 11:44:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 11:44:19 +0000 Date: Wed, 6 Nov 2013 11:44:17 +0000 (UTC) From: "Santhosh Kumar Edukulla (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (CLOUDSTACK-5056) Cleaning up SSH library MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Santhosh Kumar Edukulla reassigned CLOUDSTACK-5056: --------------------------------------------------- Assignee: Santhosh Kumar Edukulla > Cleaning up SSH library > ----------------------- > > Key: CLOUDSTACK-5056 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5056 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Automation, marvin > Reporter: Santhosh Kumar Edukulla > Assignee: Santhosh Kumar Edukulla > > Logging this bug to track issues with ssh library of marvin: > 1. The library in it current form has some issues. As part of that, did clean up of the code. > 2. Added tcp timeout flag as an additional parameter to help establish the tcp connections and retry if failed. It retries even otherwise failed. > 3. Renamed few variables and maintained uniform usage and convention. > 4. Added few new member functions runCommand,createConnection > 5. Current, way of creating connection and raising exception from constructor along with return was removed and added a new way of handling it. > 6. Currently, result list was returned for execute command, but we dont know the status of command execution, whether the output contains error or output etc. Now, provided more information in the return with new implementation. > 7. Added few codes for proper return status. > TODO: > 1. Remove establishing connection from constructor altogether. This will effect the current modules using it. > 2. Need to change is_server_ssh_ready function for proper and adequate checks, currently the name and functionality is little different. It can add more adequate checks before returning ssh object. -- This message was sent by Atlassian JIRA (v6.1#6144)