Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5616C1073B for ; Thu, 17 Oct 2013 23:48:44 +0000 (UTC) Received: (qmail 88654 invoked by uid 500); 17 Oct 2013 23:48:44 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 88639 invoked by uid 500); 17 Oct 2013 23:48:44 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 88631 invoked by uid 500); 17 Oct 2013 23:48:44 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 88628 invoked by uid 99); 17 Oct 2013 23:48:44 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2013 23:48:44 +0000 Date: Thu, 17 Oct 2013 23:48:44 +0000 (UTC) From: "Marcus Sorensen (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (CLOUDSTACK-4887) CLVM broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-4887?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Sorensen closed CLOUDSTACK-4887. --------------------------------------- > CLVM broken > ----------- > > Key: CLOUDSTACK-4887 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-488= 7 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: KVM > Affects Versions: Future > Reporter: Marcus Sorensen > Assignee: Marcus Sorensen > Priority: Blocker > Fix For: Future > > > Chris, > I think commit 180cfa19 broke CLVM primary storage for KVM. I'm failin= g VM deploy from template. I've been building a 'sanity check' test that fo= cuses on the KVM specific suff (tests storage types and supported host OS f= or now), and this bubbled up. > I reverted this one part in my local code and am testing (seems to fix it= ), but since I'm not clear on the refactor efforts I'm not sure what it sho= uld really be changed to in order to meet your requirements and keep CLVM w= orking. > @@ -65,7 +68,7 @@ public class StorageSubsystemCommandHandlerBase impleme= nts StorageSubsystemComma > DataStoreTO srcDataStore =3D srcData.getDataStore(); > DataStoreTO destDataStore =3D destData.getDataStore(); > - if ((srcData.getObjectType() =3D=3D DataObjectType.TEMPLATE) && = (srcDataStore instanceof NfsTO) && (destData.getDataStore().getRole() =3D= =3D DataStoreRole.Primary)) { > + if ((srcData.getObjectType() =3D=3D DataObjectType.TEMPLATE) && = (destData.getObjectType() =3D=3D DataObjectType.TEMPLATE && destData.getDat= aStore().getRole() =3D=3D DataStoreRole.Primary)) { > //copy template to primary storage > return processor.copyTemplateToPrimaryStorage(cmd); > } else if (srcData.getObjectType() =3D=3D DataObjectType.TEMPLAT= E && srcDataStore.getRole() =3D=3D DataStoreRole.Primary && destDataStore.g= etRole() =3D=3D DataStoreRole.Primary) { > 4.2 command: > { Cmd , MgmtId: 52241639751, via: 1, Ver: v1, Flags: 100111, [{"org.apach= e.cloudstack.storage.command.CopyCommand":{"srcTO":{"org.apache.cloudstack.= storage.to.TemplateObjectTO":{"path":"template/tmpl/1/201/fe75caa3-78fd-38b= a-b34c-101d0502df2e.qcow2","origUrl":"http://marcus.mlsorensen.com/cloudsta= ck-extras/tiny-centos-63.qcow2","uuid":"4795671b-dd72-4e62-9aac-c0e1d673200= 3","id":201,"format":"QCOW2","accountId":1,"checksum":"44cd0e6330a59f031460= bc18a40c95a2","hvm":true,"displayText":"tiny","imageDataStore":{"com.cloud.= agent.api.to.NfsTO":{"_url":"nfs://172.17.10.10:/nfs/secondary","_role":"Im= age"}},"name":"201-1-2b35186d-79a6-33dc-8b33-83eb650e5e1d","hypervisorType"= :"KVM"}},"destTO":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"uuid= ":"73f86d88-ccff-4dfb-ac86-2d76b7891117","volumeType":"ROOT","dataStore":{"= org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"08e8d399-b238= -48f9-a497-1f7f5285d655","id":2,"poolType":"CLVM","host":"localhost","path"= :"vg0","port":0}},"name":"ROOT-6","size":1073741824,"volumeId":6,"vmName":"= i-1-6-VM","accountId":1,"format":"QCOW2","id":6,"hypervisorType":"KVM"}},"e= xecuteInSequence":true,"wait":10800}}] } > 4.2 response: > { Ans: , MgmtId: 52241639751, via: 1, Ver: v1, Flags: 110, [{"org.apache.= cloudstack.storage.command.CopyCmdAnswer":{"newData":{"org.apache.cloudstac= k.storage.to.VolumeObjectTO":{"path":"f69879c0-ae3b-433a-841f-f1f5afc04fc7"= ,"accountId":0,"format":"RAW","id":0}},"result":true,"wait":0}}] } > master command: > { Cmd , MgmtId: 52241639751, via: 1(devcloud-kvm-u), Ver: v1, Flags: 1001= 11, [{"org.apache.cloudstack.storage.command.CopyCommand":{"srcTO":{"org.ap= ache.cloudstack.storage.to.TemplateObjectTO":{"path":"template/tmpl/1/4/021= 70718-210a-3d8c-91a2-2793ed52f1d8.qcow2","origUrl":"http://download.cloud.c= om/releases/2.2.0/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2","uuid":"0= 7088e98-1fda-11e3-a1ff-000c29d82947","id":4,"format":"QCOW2","accountId":1,= "checksum":"ed0e788280ff2912ea40f7f91ca7a249","hvm":false,"displayText":"Ce= ntOS 5.5(64-bit) no GUI (KVM)","imageDataStore":{"com.cloud.agent.api.to.Nf= sTO":{"_url":"nfs://172.17.10.10:/nfs/secondary","_role":"Image"}},"name":"= centos55-x86_64","hypervisorType":"KVM"}},"destTO":{"org.apache.cloudstack.= storage.to.VolumeObjectTO":{"uuid":"e08f2a84-0d8b-4c6e-9593-a7554fd57b78","= volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDa= taStoreTO":{"uuid":"0f77072d-c76f-449c-bc6d-e2504644c0ca","id":2,"poolType"= :"CLVM","host":"localhost","path":"vg0","port":0}},"name":"ROOT-7","size":8= 589934592,"volumeId":7,"vmName":"i-1-7-VM","accountId":1,"format":"QCOW2","= id":7,"hypervisorType":"KVM"}},"executeInSequence":true,"wait":10800}}] } > master response: > { Ans: , MgmtId: 52241639751, via: 1, Ver: v1, Flags: 110, [{"com.cloud.= agent.api.Answer":{"result":false,"details":"not implemented yet","wait":0}= }] } -- This message was sent by Atlassian JIRA (v6.1#6144)