Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F01DC10BCB for ; Tue, 22 Oct 2013 09:47:47 +0000 (UTC) Received: (qmail 77266 invoked by uid 500); 22 Oct 2013 09:47:45 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 77232 invoked by uid 500); 22 Oct 2013 09:47:43 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 77214 invoked by uid 500); 22 Oct 2013 09:47:42 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 77210 invoked by uid 99); 22 Oct 2013 09:47:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Oct 2013 09:47:42 +0000 Date: Tue, 22 Oct 2013 09:47:41 +0000 (UTC) From: "Sanjeev N (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (CLOUDSTACK-4586) CIDR validation is not happening for Authorizing egress rule command MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-4586?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjeev N closed CLOUDSTACK-4586. --------------------------------- Verified this with latest build from 4.2 branch. Works fine. > CIDR validation is not happening for Authorizing egress rule command > -------------------------------------------------------------------- > > Key: CLOUDSTACK-4586 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-458= 6 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: Automation > Affects Versions: 4.2.1 > Reporter: venkata swamybabu budumuru > Assignee: Jayapal Reddy > Priority: Critical > Fix For: 4.2.1 > > > Here is the marvin failure snippet > integration.component.test_egress_rules.TestInvalidParametersForEgress.te= st_invalid_parameters > Swamys-MacBook-Air:component swamy$ nosetests --with-marvin --marvin-conf= ig=3D/Users/swamy/hudson/scripts/demo.cfg --load test_egress_rules.py -a ta= gs=3Dswamy > Test invalid parameters for egress rules ... FAIL > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > FAIL: Test invalid parameters for egress rules > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/Users/swamy/incubator-cloudstack/test/integration/component/test= _egress_rules.py", line 2098, in test_invalid_parameters > domainid=3Dself.account.domainid > AssertionError: Exception not raised > -------------------- >> begin captured logging << -------------------- > test_invalid_parameters (integration.component.test_egress_rules.TestInva= lidParametersForEgress): DEBUG: Created security group with ID: c872aced-5f= 69-453d-a676-5323b43ed539 > test_invalid_parameters (integration.component.test_egress_rules.TestInva= lidParametersForEgress): DEBUG: Authorizing egress rule for sec group ID: c= 872aced-5f69-453d-a676-5323b43ed539 with invalid port > test_invalid_parameters (integration.component.test_egress_rules.TestInva= lidParametersForEgress): DEBUG: Authorizing egress rule for sec group ID: c= 872aced-5f69-453d-a676-5323b43ed539 with invalid cidr > --------------------- >> end captured logging << --------------------- > ---------------------------------------------------------------------- > Ran 1 test in 12.973s > FAILED (failures=3D1) > Here are the list of params passed to the API: > "sg_invalid_cidr": { > "name": 'SSH', > "protocol": 'TCP', > "startport": 22, > "endport": 22, > "cidrlist": '0.0.0.10' > }, > Snippet from management server logs: > 2013-08-31 23:23:37,915 DEBUG [cloud.api.ApiServlet] (catalina-exec-22:nu= ll) =3D=3D=3DEND=3D=3D=3D 10.101.255.126 -- GET signature=3DwWuDyStudYe2D= YuqfKGowUEgcyk%3D&apiKey=3DBjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t= 2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=3DqueryAsyncJobResult&respon= se=3Djson&jobid=3D2693054d-b5cb-472e-9100-d18a92cbf294 > 2013-08-31 23:23:39,001 DEBUG [cloud.api.ApiServlet] (catalina-exec-16:nu= ll) =3D=3D=3DSTART=3D=3D=3D 10.101.255.126 -- GET account=3Dtest-TestAuth= orizeIngressRule-ODEG8D&domainid=3D6fdbc1ec-11e2-11e3-9e2f-4290361b938f&pro= tocol=3DTCP&endport=3D22&cidrlist=3D0.0.0.10&securitygroupid=3D64ccf96c-741= 1-4a02-a907-6b94bc79a1fb&apiKey=3DBjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei= -2nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=3DauthorizeSecurityGr= oupEgress&signature=3D41Ngeocn%2Bli8D0tRPvXSvdpg0oA%3D&startport=3D22&respo= nse=3Djson > 2013-08-31 23:23:39,027 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Exec= utor-129:job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea446d91 ]) Executing o= rg.apache.cloudstack.api.command.user.securitygroup.AuthorizeSecurityGroupE= gressCmd for job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea446d91 ] > 2013-08-31 23:23:39,031 DEBUG [cloud.async.AsyncJobManagerImpl] (catalina= -exec-16:null) submit async job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea44= 6d91 ], details: AsyncJobVO {id:1125, userId: 2, accountId: 2, sessionKey: = null, instanceType: SecurityGroup, instanceId: 302, cmd: org.apache.cloudst= ack.api.command.user.securitygroup.AuthorizeSecurityGroupEgressCmd, cmdOrig= inator: null, cmdInfo: {"protocol":"TCP","cmdEventType":"SG.AUTH.EGRESS","c= txUserId":"2","securitygroupid":"64ccf96c-7411-4a02-a907-6b94bc79a1fb","htt= pmethod":"GET","startport":"22","domainid":"6fdbc1ec-11e2-11e3-9e2f-4290361= b938f","endport":"22","apiKey":"BjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2= nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ","response":"json","account":"t= est-TestAuthorizeIngressRule-ODEG8D","cidrlist":"0.0.0.10","ctxAccountId":"= 2","ctxStartEventId":"4281","signature":"41Ngeocn+li8D0tRPvXSvdpg0oA\u003d"= }, cmdVersion: 0, callbackType: 0, callbackAddress: null, status: 0, proces= sStatus: 0, resultCode: 0, result: null, initMsid: 73187150500751, complete= Msid: null, lastUpdated: null, lastPolled: null, created: null} > 2013-08-31 23:23:39,033 DEBUG [cloud.api.ApiServlet] (catalina-exec-16:nu= ll) =3D=3D=3DEND=3D=3D=3D 10.101.255.126 -- GET account=3Dtest-TestAuthor= izeIngressRule-ODEG8D&domainid=3D6fdbc1ec-11e2-11e3-9e2f-4290361b938f&proto= col=3DTCP&endport=3D22&cidrlist=3D0.0.0.10&securitygroupid=3D64ccf96c-7411-= 4a02-a907-6b94bc79a1fb&apiKey=3DBjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2= nuH-t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=3DauthorizeSecurityGrou= pEgress&signature=3D41Ngeocn%2Bli8D0tRPvXSvdpg0oA%3D&startport=3D22&respons= e=3Djson > 2013-08-31 23:23:39,056 DEBUG [network.security.SecurityGroupManagerImpl]= (Job-Executor-129:job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea446d91 ]) A= dded 1 rules to security group SSH > 2013-08-31 23:23:39,071 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Exec= utor-129:job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea446d91 ]) Complete as= ync job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea446d91 ], jobStatus: 1, re= sultCode: 0, result: org.apache.cloudstack.api.response.SecurityGroupRespon= se@6cbd7086 > 2013-08-31 23:23:39,093 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Exec= utor-129:job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea446d91 ]) Done execut= ing org.apache.cloudstack.api.command.user.securitygroup.AuthorizeSecurityG= roupEgressCmd for job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea446d91 ] > 2013-08-31 23:23:39,995 DEBUG [cloud.api.ApiServlet] (catalina-exec-18:nu= ll) =3D=3D=3DSTART=3D=3D=3D 10.101.255.126 -- GET signature=3DSrC9Y8DfcLW= vu6b5LoBbbArsaN0%3D&apiKey=3DBjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH= -t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=3DqueryAsyncJobResult&resp= onse=3Djson&jobid=3D509996f5-1167-4c7b-a69d-b796ea446d91 > 2013-08-31 23:23:40,004 DEBUG [cloud.async.AsyncJobManagerImpl] (catalina= -exec-18:null) Async job-1125 =3D [ 509996f5-1167-4c7b-a69d-b796ea446d91 ] = completed > 2013-08-31 23:23:40,007 DEBUG [cloud.api.ApiServlet] (catalina-exec-18:nu= ll) =3D=3D=3DEND=3D=3D=3D 10.101.255.126 -- GET signature=3DSrC9Y8DfcLWvu= 6b5LoBbbArsaN0%3D&apiKey=3DBjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-t= 2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=3DqueryAsyncJobResult&respon= se=3Djson&jobid=3D509996f5-1167-4c7b-a69d-b796ea446d91 > 2013-08-31 23:23:40,844 DEBUG [cloud.storage.StorageManagerImpl] (Storage= Manager-Scavenger-3:null) Storage pool garbage collector found 0 templates = to clean up in storage pool: PS0 > 2013-08-31 23:23:40,847 DEBUG [cloud.storage.StorageManagerImpl] (Storage= Manager-Scavenger-3:null) Storage pool garbage collector found 0 templates = to clean up in storage pool: PS1 > 2013-08-31 23:23:40,850 DEBUG [cloud.storage.StorageManagerImpl] (Storage= Manager-Scavenger-3:null) Secondary storage garbage collector found 0 templ= ates to cleanup on template_store_ref for store: nfs://nfs1-ccp.citrix.com:= /home/common/automation/SC_QA_AUTO5/secondary1 > 2013-08-31 23:23:40,851 DEBUG [cloud.storage.StorageManagerImpl] (Storage= Manager-Scavenger-3:null) Secondary storage garbage collector found 0 snaps= hots to cleanup on snapshot_store_ref for store: nfs://nfs1-ccp.citrix.com:= /home/common/automation/SC_QA_AUTO5/secondary1 > 2013-08-31 23:23:40,852 DEBUG [cloud.storage.StorageManagerImpl] (Storage= Manager-Scavenger-3:null) Secondary storage garbage collector found 0 volum= es to cleanup on volume_store_ref for store: nfs://nfs1-ccp.citrix.com:/hom= e/common/automation/SC_QA_AUTO5/secondary1 > 2013-08-31 23:23:41,022 DEBUG [cloud.api.ApiServlet] (catalina-exec-5:nul= l) =3D=3D=3DSTART=3D=3D=3D 10.101.255.126 -- GET signature=3DhPbLa6LtbvGq= PhXKeByWzgrkGTM%3D&apiKey=3DBjjfseQrt3qH2nkBIesJs8ZIUoS4yM65Mk_ZSoJei-2nuH-= t2Y8M4amNdE4OgPUfVzbSO9PRUaeupxnkfZfHAQ&command=3DdeleteAccount&id=3D054ca0= 1e-b508-42ae-ad64-1fc42cb25a72&response=3Djson -- This message was sent by Atlassian JIRA (v6.1#6144)