Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44741104F0 for ; Tue, 22 Oct 2013 05:14:44 +0000 (UTC) Received: (qmail 48766 invoked by uid 500); 22 Oct 2013 05:14:43 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 48748 invoked by uid 500); 22 Oct 2013 05:14:42 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 48736 invoked by uid 500); 22 Oct 2013 05:14:42 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 48732 invoked by uid 99); 22 Oct 2013 05:14:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Oct 2013 05:14:42 +0000 Date: Tue, 22 Oct 2013 05:14:41 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-4493) registerSSHKeyPair API doc contains wrong API response (private key) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801491#comment-13801491 ] ASF subversion and git services commented on CLOUDSTACK-4493: ------------------------------------------------------------- Commit 54e365d00b5ae504c59c025b37387b9c9d166422 in branch refs/heads/master from [~harikrishna.patnala] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=54e365d ] CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key) Changing the response object of register and list ssh keypairs APIs Signed-off-by: Koushik Das Conflicts: api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java > registerSSHKeyPair API doc contains wrong API response (private key) > -------------------------------------------------------------------- > > Key: CLOUDSTACK-4493 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4493 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Reporter: Harikrishna Patnala > Assignee: Harikrishna Patnala > Priority: Critical > Fix For: 4.2.1, 4.3.0 > > > registerSSHKeyPair API returns only name and fingerprint of the ssh keypair (sets null to private key parameter). > Our API doc http://cloudstack.apache.org/docs/api/apidocs-4.1/user/registerSSHKeyPair.html > has an extra parameter private key in response which anyway we return null. > Response Name : Description > ------------------------------------------------- > fingerprint : Fingerprint of the public key > name : Name of the keypair > privatekey : Private key > This is because we use same response object for all ssh key pair related APIs. > In this case it is misleading and seems like CS API leaks implementation details. -- This message was sent by Atlassian JIRA (v6.1#6144)