Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 961C5105BA for ; Tue, 10 Sep 2013 08:46:54 +0000 (UTC) Received: (qmail 86802 invoked by uid 500); 10 Sep 2013 08:46:54 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 86772 invoked by uid 500); 10 Sep 2013 08:46:53 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 86740 invoked by uid 500); 10 Sep 2013 08:46:52 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 86723 invoked by uid 99); 10 Sep 2013 08:46:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Sep 2013 08:46:52 +0000 Date: Tue, 10 Sep 2013 08:46:52 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-4466) DHCP capability breaks in 4.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762857#comment-13762857 ] ASF subversion and git services commented on CLOUDSTACK-4466: ------------------------------------------------------------- Commit 28af817fcc835c10e4a21f08e971041325ad206d in branch refs/heads/master from [~davecahill] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=28af817 ] CLOUDSTACK-4466: Fix DHCP capability breaks in 4.2 for MidoNet A recent code change in NetworkManager causes NullPointerExceptions when DHCP capability list is null. The commit which made the NetworkManager change also changed the VirtualRouter to not use null for the capabilitylist, but didn't make this change for other network devices, causing DHCP to fail on MidoNet. This change also updates the MidoNet plugin to use the most recent MidoNet API. > DHCP capability breaks in 4.2 > ----------------------------- > > Key: CLOUDSTACK-4466 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4466 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Network Devices > Affects Versions: 4.2.0 > Reporter: Dave Cahill > Assignee: Dave Cahill > Fix For: 4.2.1 > > > Prior to this change, the default "capabilities" for DHCP list was null. > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=956a2a68cebc1b4427bc20ff0e7790ef9846893c > The change causes a NullPointerException if the DHCP capabilities list is null. The change replaces null in the VirtualRouterElement to avoid the NPE, but leaves other elements which were using null for the DHCP capabilities list broken. > This causes an NPE and failure to implement DHCP. From a quick code grep, it looks like MidoNet is the only network plugin affected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira