Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F4F210BBD for ; Tue, 20 Aug 2013 18:06:54 +0000 (UTC) Received: (qmail 25826 invoked by uid 500); 20 Aug 2013 18:06:54 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 25814 invoked by uid 500); 20 Aug 2013 18:06:54 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 25671 invoked by uid 500); 20 Aug 2013 18:06:53 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 25417 invoked by uid 99); 20 Aug 2013 18:06:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Aug 2013 18:06:53 +0000 Date: Tue, 20 Aug 2013 18:06:53 +0000 (UTC) From: "Parth Jagirdar (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (CLOUDSTACK-3821) RegisterTemplate URL validation issue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Jagirdar closed CLOUDSTACK-3821. -------------------------------------- Verified, Successfully registered a template with Query that "Does not" end with extension. http://10.223.132.160:8080/client/api?command=registerTemplate&response=json&sessionkey=RrzEgphSIINbs%2FHyZoB9sePVq2Y%3D&name=ZCA-6.0.13.406-412056.ova&displayText=ZCA-6.0.13.406-412056.ova&url=http%3A%2F%2Fnfs1.lab.vmops.com%2Ftemplates%2FZCA-6.0.13.406-412056.ova&zoneid=-1&format=OVA&isextractable=false&passwordEnabled=false&isdynamicallyscalable=false&osTypeId=30459d2a-05ce-11e3-9b38-066a9a000451&hypervisor=VMware&ispublic=false&isfeatured=false&isrouting=false&_=1377021771522 { "registertemplateresponse" : { "count":1 ,"template" : [ {"id":"4cdcdd0f-c91f-41d6-a9e6-e115f6a58374","name":"ZCA-6.0.13.406-412056.ova","displaytext":"ZCA-6.0.13.406-412056.ova","ispublic":false,"created":"2013-08-20T11:03:05-0700","isready":false,"passwordenabled":false,"format":"OVA","isfeatured":false,"crossZones":true,"ostypeid":"30459d2a-05ce-11e3-9b38-066a9a000451","ostypename":"Other (64-bit)","account":"admin","zoneid":"81a4be0d-67c3-460c-acb8-e61748fdde3b","zonename":"Z","status":"","templatetype":"USER","hypervisor":"VMware","domain":"ROOT","domainid":"269f202a-05ce-11e3-9b38-066a9a000451","isextractable":false,"tags":[],"sshkeyenabled":false,"isdynamicallyscalable":false} ] } } > RegisterTemplate URL validation issue > -------------------------------------- > > Key: CLOUDSTACK-3821 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3821 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Affects Versions: 4.2.0 > Reporter: Prachi Damle > Assignee: Prachi Damle > Fix For: 4.2.0 > > > The current validation method implemented in Cloudstack checks the entire URL to ensure that it ends with a template extension. If the template URL includes query string parameters the validation > will not pass even though the URL is a valid image. > This can be fixed by checking only the path for the extension and not the full URL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira