cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "edison su (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-3937) Attaching uploaded volume is failing
Date Tue, 30 Jul 2013 17:55:54 GMT


edison su commented on CLOUDSTACK-3937:

The fix has another problem, it will break vmware logic, such as create template from snapshot,
the host is a ssvm agent, not related to any hypervisor.
> Attaching uploaded volume is failing
> ------------------------------------
>                 Key: CLOUDSTACK-3937
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Storage Controller
>    Affects Versions: 4.2.0
>            Reporter: Koushik Das
>            Assignee: Koushik Das
>            Priority: Blocker
>             Fix For: 4.2.0
> This got introduced as part of bfe30cd2e31906365a306d87fe331ccdcec5c33c.
> The uploaded volume is first copied from secondary to primary and then attached to a
VM. Due to the above commit the copy logic is broken in all HVs except Vmware.
> There is a method
>     public Pair<Boolean, Long> getCommandHostDelegation(long hostId, Command cmd)
> that is overidden in and not in any other specific HV guru.
> Earlier this method was not overridden in any HV guru and so the below method used to
fall back on the default behavior and used to return the passed hostId but now with the Vmware
guru implementation request for any HV gets processed by Vmware guru and results in NPE.
>     public long getGuruProcessedCommandTargetHost(long hostId, Command cmd) {
>         for(HypervisorGuru guru : _hvGuruList) {
>             Pair<Boolean, Long> result = guru.getCommandHostDelegation(hostId,
>             if (result.first()) {
>                 return result.second();
>             }
>         }
>         return hostId;
>     }

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message