cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CLOUDSTACK-3467) Fix unit tests for implicit dedication planner
Date Thu, 11 Jul 2013 10:17:51 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Devdeep Singh updated CLOUDSTACK-3467:
--------------------------------------

    Description: When bug CLOUDSTACK-2662 was fixed for implicit dedication planner, the unit
tests were not updated in a correct way. The fix had made a change to not to ignore system
vms, so instead of using a userVmDao, the planner started using vmInstanceDao to query the
running vms on a host. However, the unit test for the planner weren't updated correctly. They
should have been updated to return the right mock object (of type VMInstanceVO) when the vmInstanceDao
is queried for vm on a host. It needs to be fixed.  (was: When bug CLOUDSTACK-2662 was fixed
for implicit dedication planner, the unit tests were not updated in a correct way. The fix
had made a change to not to ignore system vms, so instead of using a userVmDao we the planner
started using vmInstanceDao to query the running vms on a host. However, the unit test for
the planner weren't updated correctly. They should have been updated to return the right mock
object (of type VMInstanceVO) when the vmInstanceDao is queried for vm on a host. It needs
to be fixed.)
    
> Fix unit tests for implicit dedication planner
> ----------------------------------------------
>
>                 Key: CLOUDSTACK-3467
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3467
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.2.0
>            Reporter: Devdeep Singh
>            Assignee: Devdeep Singh
>            Priority: Critical
>             Fix For: 4.2.0
>
>
> When bug CLOUDSTACK-2662 was fixed for implicit dedication planner, the unit tests were
not updated in a correct way. The fix had made a change to not to ignore system vms, so instead
of using a userVmDao, the planner started using vmInstanceDao to query the running vms on
a host. However, the unit test for the planner weren't updated correctly. They should have
been updated to return the right mock object (of type VMInstanceVO) when the vmInstanceDao
is queried for vm on a host. It needs to be fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message