cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alena Prokharchyk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-3015) VPC virtual router lists deleted nics
Date Tue, 18 Jun 2013 23:07:20 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687349#comment-13687349
] 

Alena Prokharchyk commented on CLOUDSTACK-3015:
-----------------------------------------------

1) listRouters problem

Min, can you please take a look at this bug. Its related to the view system you've introduced
for the VR. Although the VR's nic is removed, the entry for this nic is still present in the
view table, so the API returns it back to the user - bug.


mysql> select id, ip4_address, removed from nics where instance_id=3;
+----+---------------+---------------------+
| id | ip4_address   | removed             |
+----+---------------+---------------------+
|  8 | 169.254.1.46  | NULL                |
|  9 | 10.223.159.12 | NULL                |
| 11 | 10.1.1.1      | 2013-06-18 22:43:06 |
+----+---------------+---------------------+
3 rows in set (0.00 sec)

mysql> select name, ip_address from domain_router_view;
+--------+---------------+
| name   | ip_address    |
+--------+---------------+
| r-3-st | 169.254.1.46  |
| r-3-st | 10.223.159.12 |
| r-3-st | 10.1.1.1      |
+--------+---------------+
3 rows in set (0.00 sec)

In the VPC the nics on the VR are dynamic, and can change with the time. The view should reflect
those changes.


2) Marcus, the problem with the VPC removal (NPE for the VLAN) is caused by diff problem introduced
by commit a49261c3b1f2d52d637f481e0bcff4b0d58d7b56. This commit changed getNicInNetwork in
NetworkModelImpl to return nics that were marked as removed. So when we tried to remove the
VPC, we've tried to access the removed nic entry. The problem was fixed with c1ad3b7974449f457a1cc4e50fe7af260d1c5bf6

3) I don't see the problems with the VM start after the network was initially shutdown, in
the latest build. After the network is shutdown (remember, shutdown happens only when there
are no running user vms in the system), and re-implemented again with the new vlan as a part
of new user vm start, both user vm and vr nics were configured with the new vlan.


Before network shutdown (vlan=2004):

mysql> select id, ip4_address, removed, broadcast_uri, vm_type from nics where instance_id
in (5,6) and network_id=205;
+----+-------------+---------+---------------+--------------+
| id | ip4_address | removed | broadcast_uri | vm_type      |
+----+-------------+---------+---------------+--------------+
| 14 | 10.1.1.165  | NULL    | vlan://2004   | User         |
| 15 | 10.1.1.1    | NULL    | vlan://2004   | DomainRouter |
+----+-------------+---------+---------------+--------------+

After network was shutdown (vlan is released; nic from the guest network is marked as removed
on the VR):

mysql> select id, ip4_address, removed, broadcast_uri, vm_type from nics where instance_id
in (5,6) and network_id=205;
+----+-------------+---------------------+---------------+--------------+
| id | ip4_address | removed             | broadcast_uri | vm_type      |
+----+-------------+---------------------+---------------+--------------+
| 14 | 10.1.1.165  | NULL                | NULL          | User         |
| 15 | 10.1.1.1    | 2013-06-18 23:04:12 | NULL          | DomainRouter |
+----+-------------+---------------------+---------------+--------------+

 and implemented again (new vlan=2049 is allocated for both VR and user vm) :

mysql> select id, ip4_address, removed, broadcast_uri, vm_type from nics where instance_id
in (5,6) and network_id=205;
+----+-------------+---------------------+---------------+--------------+
| id | ip4_address | removed             | broadcast_uri | vm_type      |
+----+-------------+---------------------+---------------+--------------+
| 14 | 10.1.1.165  | NULL                | vlan://2049   | User         |
| 15 | 10.1.1.1    | 2013-06-18 23:04:12 | NULL          | DomainRouter |
| 16 | 10.1.1.1    | NULL                | vlan://2049   | DomainRouter |
+----+-------------+---------------------+---------------+--------------+


So the only one problem that is left - fixing the API response in listRouters command.

                
> VPC virtual router lists deleted nics
> -------------------------------------
>
>                 Key: CLOUDSTACK-3015
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3015
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.1.0, 4.2.0
>            Reporter: Marcus Sorensen
>            Assignee: Alena Prokharchyk
>            Priority: Blocker
>              Labels: integration-test
>             Fix For: 4.1.1, 4.2.0
>
>
> Create a VPC
> Create a network in VPC
> Create a VM in network in VPC
> Shut down VM
> Wait awhile
> Observed: Something cleans up the unused network in the VPC, removing the guest network
nic from the VPC router.
> Start VM
> Observed: New nic is allocated for VPC router
> List routers
> Observed: Router shows both old and new nics.
> We need to either avoid cleaning up these nics when the aren't used, or avoid showing
them whenever a VPC/router is queried for nics.
> As a bonus, I've occasionally seen vpcs fail to be deletable. It seemed to be because
some of its nics had no broadcast URI (the removed ones), and a NULL pointer was thrown.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message