Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC37E1085A for ; Fri, 31 May 2013 12:22:27 +0000 (UTC) Received: (qmail 44959 invoked by uid 500); 31 May 2013 12:22:22 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 44848 invoked by uid 500); 31 May 2013 12:22:21 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 44818 invoked by uid 500); 31 May 2013 12:22:21 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 44795 invoked by uid 99); 31 May 2013 12:22:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 May 2013 12:22:20 +0000 Date: Fri, 31 May 2013 12:22:20 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-2787) updateVpcOffering should have id as a required attribute MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671387#comment-13671387 ] ASF subversion and git services commented on CLOUDSTACK-2787: ------------------------------------------------------------- Commit aefcee5753d4a050bdb38fd1a51f1e1de1a634ae in branch refs/heads/master from [~tsp] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=aefcee5 ] CLOUDSTACK-2787: updateVpcOffering should have id as a required without the id you cannot update a VPC offering. The docs for API will go wrong and Marvin tests using update VPC will fail. Signed-off-by: Prasanna Santhanam > updateVpcOffering should have id as a required attribute > -------------------------------------------------------- > > Key: CLOUDSTACK-2787 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2787 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: API > Affects Versions: 4.2.0 > Reporter: Prasanna Santhanam > Fix For: 4.2.0 > > > id is not a required attribute in updateVpcOfferingCmd.java but without the id one cannot update the vpc offering. > @APICommand(name = "updateVPCOffering", description="Updates VPC offering", responseObject=VpcOfferingResponse.class) > public class UpdateVPCOfferingCmd extends BaseAsyncCmd{ > public static final Logger s_logger = Logger.getLogger(UpdateVPCOfferingCmd.class.getName()); > private static final String _name = "updatevpcofferingresponse"; > ///////////////////////////////////////////////////// > //////////////// API parameters ///////////////////// > ///////////////////////////////////////////////////// > @Parameter(name=ApiConstants.ID, type=CommandType.UUID, entityType = VpcOfferingResponse.class, > description="the id of the VPC offering") > private Long id; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira