Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 2 Apr 2013 06:17:14 +0000 (UTC)
From: "Wido den Hollander (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12630866.1360068967064.90301.1364883434786@arcas>
In-Reply-To: <JIRA.12630866.1360068967064@arcas>
References: <JIRA.12630866.1360068967064@arcas>
Subject: [jira] [Resolved] (CLOUDSTACK-1158) Wrap qemu-img instead of using
 simpleBashScript
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CLOUDSTACK-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wido den Hollander resolved CLOUDSTACK-1158.
--------------------------------------------

    Resolution: Fixed

Merged into master after review by Edison.
                
> Wrap qemu-img instead of using simpleBashScript
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-1158
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1158
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: 4.0.0
>            Reporter: Wido den Hollander
>            Assignee: Wido den Hollander
>             Fix For: 4.2.0
>
>
> Currently when we are doing something with qemu-img in the KVM Agent we do things like this:
> ..
> String result = executeBashScript("qemu-img --help|grep convert");
> ..
> Script.runSimpleBashScript("qemu-img convert"
> ..
> This is not reliable and could be fixed by wrapping qemu-img like this:
> QemuImg.convert(String sourceFormat, String source, String destFormat, string dest);
> This could then handle all  the stuff like checking the output and more importantly also checking the exit status of Qemu to see if everything works.
> It could throw exceptions where needed so it makes life easier when doing such operations in the KVM Agent.
> Hopefully we can then also get rid of all kinds of bash scripts being called by the KVM Agent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira