Mailing-List: contact cloudstack-issues-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Date: Wed, 6 Mar 2013 08:48:14 +0000 (UTC)
From: "Pranav Saxena (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12635496.1362548288920.390379.1362559694937@arcas>
In-Reply-To: <JIRA.12635496.1362548288920@arcas>
References: <JIRA.12635496.1362548288920@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-1528) No UI level check for
 Overcommit ratio;It is accepting special character,negative values and zero
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594499#comment-13594499 ] 

Pranav Saxena commented on CLOUDSTACK-1528:
-------------------------------------------

So the UI can check for a negative value or special characters but typically the API layer is supposed to do all these validations , if you go by the code symmetry . The invalid values should be caught as exceptions and thrown on the UI with an error message being rendered from the API . I would suggest we have these checks at the API layer.

Secondly , I can add some basic checks at the UI layer too along with the tooltips which highlight , what sort of input values are valid ones. 

Thanks,
Pranav
                
> No UI level check for Overcommit ratio;It is accepting special character,negative values and zero
> -------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-1528
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1528
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: UI
>    Affects Versions: 4.2.0
>            Reporter: prashant kumar mishra
>             Fix For: 4.2.0
>
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg
>
>
> 1-There is no check in UI for special character and zero.
> 2-If we provide any special character or zero for overcommit ratio in UI ,DB is getting upgraded by default value 1.
> Steps
> --------
> 1-Create a cluster provide some special characters for overcommit ratio
> Expected
> -------------
> should have some error message , overcommite ratio cant't be special character or less than zero etc.
> Actual
> ------------
> cluster is getting created with overcommit ratio ={special character,zero,-ive values} but DB is storing default value 1 .
> DB
> -------
> mysql> select* from cluster_details;
> +----+------------+-----------------------+-------+
> | id | cluster_id | name                  | value |
> +----+------------+-----------------------+-------+
> |  1 |          1 | cpuOvercommitRatio    | 1.0   |
> |  2 |          1 | memoryOvercommitRatio | 1.0   |
> |  3 |          2 | cpuOvercommitRatio    | 1.0   |
> |  4 |          2 | memoryOvercommitRatio | 1.0   |
> |  5 |          3 | cpuOvercommitRatio    | 1.0   |
> |  6 |          3 | memoryOvercommitRatio | 1.0   |
> +----+------------+-----------------------+-------+

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira