cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #853: addldapaccount: Fix defensive check
Date Mon, 09 Nov 2020 11:35:13 GMT

davidjumani commented on a change in pull request #853:
URL: https://github.com/apache/cloudstack-primate/pull/853#discussion_r519741977



##########
File path: src/views/iam/AddLdapAccount.vue
##########
@@ -283,7 +283,7 @@ export default {
       params.domainid = store.getters.userInfo.domainid
       if (domain) {
         const result = this.listDomains.filter(item => item.name === domain)
-        if (result) {
+        if (result.length > 0) {

Review comment:
       Can't be none. Either an empty list or a single item




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message