cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tutkowski, Mike" <Mike.Tutkow...@netapp.com>
Subject Re: [GitHub] rafaelweingartner commented on a change in pull request #2761: Add managed storage pool constraints to MigrateWithVolume API method
Date Wed, 25 Jul 2018 20:57:36 GMT
That is correct (that is how the old behavior worked).

On 7/25/18, 2:56 PM, "GitBox" <git@apache.org> wrote:

    rafaelweingartner commented on a change in pull request #2761: Add managed storage pool
constraints to MigrateWithVolume API method
    URL: https://github.com/apache/cloudstack/pull/2761#discussion_r205259766
     
     
    
     ##########
     File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
     ##########
     @@ -2282,7 +2282,7 @@ protected void migrate(final VMInstanceVO vm, final long srcHostId,
final Deploy
          * Create the mapping of volumes and storage pools. If the user did not enter a mapping
on her/his own, we create one using {@link #getDefaultMappingOfVolumesAndStoragePoolForMigration(VirtualMachineProfile,
Host)}.
          * If the user provided a mapping, we use whatever the user has provided (check the
method {@link #createMappingVolumeAndStoragePoolEnteredByUser(VirtualMachineProfile, Host,
Map)}).
          */
    -    private Map<Volume, StoragePool> getPoolListForVolumesForMigration(VirtualMachineProfile
profile, Host targetHost, Map<Long, Long> volumeToPool) {
    +    protected Map<Volume, StoragePool> getPoolListForVolumesForMigration(VirtualMachineProfile
profile, Host targetHost, Map<Long, Long> volumeToPool) {
     
     Review comment:
       Ok, so to summarize. If the VM has two volumes, you want to be able to define the migration
for one of them and the other that was not specified should be taken care by ACS. Is that
it? 
    
    ----------------------------------------------------------------
    This is an automated message from the Apache Git Service.
    To respond to the message, please log on GitHub and use the
    URL above to go to the specific comment.
     
    For queries about this service, please contact Infrastructure at:
    users@infra.apache.org
    
    
    With regards,
    Apache Git Services
    

Mime
View raw message