From dev-return-111610-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Thu Jun 21 20:44:02 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9836018062B for ; Thu, 21 Jun 2018 20:44:01 +0200 (CEST) Received: (qmail 97267 invoked by uid 500); 21 Jun 2018 18:44:00 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 97204 invoked by uid 99); 21 Jun 2018 18:43:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jun 2018 18:43:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4DBE7C18D9 for ; Thu, 21 Jun 2018 18:43:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.3 X-Spam-Level: X-Spam-Status: No, score=0.3 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9V_AjslWiag3 for ; Thu, 21 Jun 2018 18:43:57 +0000 (UTC) Received: from se01-out.mail.pcextreme.nl (se01-out.mail.pcextreme.nl [185.66.251.200]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 508CE5F2F0 for ; Thu, 21 Jun 2018 18:43:57 +0000 (UTC) Subject: Re: Working with a 'PendingReleaseNotes' file To: dev@cloudstack.apache.org, Daan Hoogland Cc: =?UTF-8?Q?Rafael_Weing=c3=a4rtner?= References: <1d4e90c1-412e-6f42-0b61-6fa0c10cef96@widodh.nl> <4d24f8b8-45f8-6aea-c569-4aedc419ab4b@widodh.nl> From: Wido den Hollander Openpgp: preference=signencrypt Autocrypt: addr=wido@widodh.nl; prefer-encrypt=mutual; keydata= xsBNBFPkomgBCADGA8E8Wm2bG2lSTggjk4i6iEHEA6EZJ9Ln2nTIGPg+QbRAZSYuPBtr0d6K kijiFzh0oujoQ5Q6UlK1sp3on7PIsmKeK5K54Ji+is28xPaUAoEVteTb/2XuLon/sobO+fzM v2nrZ63owjQRMUtuR9vJmZ+aODq0WyHUj4bw1WVIL3PBkQ5QuwDA6u5e/UlugvdVf+GMCFOM wOo8mh6IRtYQTqoUkiGydrAM8gFbOTA9rO4bFpbSbiu/e9FbDwdmj370YHFVd6s/wgNtOeKs pQVdWD8tJI8eI8g0L/HYfxD69BTnyI0YPjI1n/aDHRvh0F1usYoTXb2/18pDPNcjVfxvABEB AAHNO1dpZG8gZGVuIEhvbGxhbmRlciAoUENleHRyZW1lIEIuVi4ga2V5KSA8d2lkb0BwY2V4 dHJlbWUubmw+wsB4BBMBAgAiBQJT5KJoAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAK CRB9xvI4O0zu2g9wB/9l6xuaRF1J3gQB7jAg/B2PnOM4KmjoFPMGSMtKs94rLoqmcn5GUD4H JEdSiP5USqh0OnLN6Knb1ZAASWzLOji9QLq+nPI8zjeMXChF2Qf7/qkP75MslH3wBxy16yl2 0yvd7wqZZXbc7vKSkxVMvJdxqf738d+Zc38u0z0cV43h77T3CvxZuEA13WeHK/eHQCXx3sBl zrjfylM0UbIDhntNWe9q5BYtOOQJpfq9t7DQwTQ6m7VFMrFBExP3ZdHIOvFKesrHyGAJLMw+ 8nMeEdWOe9TEsBgmhxny5TJmygNcekuzoaWSknyHn7vwLNSESejs/Vs3/duv/luZWbkpvaq/ zsBNBFPkomgBCACbkn7d8A2z/4691apLM07NyvkXBON7+HPtBm7LFJ2YnVcfc1AaX6d8XVnG s5aKMqaa5+ZVDpvKX0rUE9B8neQQ0UwUaEG8QlSuilBfAbDA1+8NtjIkoo7Vcy0PTJ1kGhgV D4cD98SIT+NpCB0Om9D80O14YP+ES9pkL3XEcixPy7LpLVTVMz2ZH1PXZy/pm7AdSHX/xcKG SctiO2C8jWq0VZdoQSP5hhnf4FOZdhTnp2bZFFgC/5EQ3tTrBMOJiftmOFf5ai5CLffoBRqN 8e8wsVohcdRKEDvMtdKJntncG3pmJIuDMSWQxhM1LrZ7UgeSBbrS+vCdyKplXwdDw/GJABEB AAHCwF8EGAECAAkFAlPkomgCGwwACgkQfcbyODtM7trA2gf/Ydp28gq6PFZZAycM4n4bUQ2p E34E91VBpJZlYGHJWoBbkBgf6eAzkWXZq2sDnnAjxPP9H7RWyPZGH4xRB4U7JdtAD4z46gWT 8qoWvkbwfZlrmxEPkyTIi05msiNYRk6iGOkb5Oob0yp03ROxZRGljiiLzS44BgK9M+n67DxC IlhSiSotHSfljbMUeMj1VXLrmusEw7Dtds5LzON2UZFd/AUJP6zj9GHCpTsvEwacsCdia683 44jzAsFJLduXHdNa9SKlreahe8fGmv8CAtQpD4OuLiDsqzzwkKPI6GAd1MqJQh5AwM0HarPt oDhu3Bo+SVdO5LIKLCmujjBbHZBHIw== Message-ID: <0d99ca23-2bd9-8f17-3b78-7a8403900eaa@widodh.nl> Date: Thu, 21 Jun 2018 20:43:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: 2a00:f10:400:2:425:b2ff:fe00:1c1 X-SpamExperts-Domain: out.pcextreme.nl X-SpamExperts-Username: 2a00:f10:400:2:425:b2ff:fe00:1c1 Authentication-Results: mail.pcextreme.nl; auth=pass smtp.auth=2a00:f10:400:2:425:b2ff:fe00:1c1@out.pcextreme.nl X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.04) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5rPh53Gs334zoj6XlwJBkW9602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO8iOFiy1Zh+at7ab+mPudvOPIwKqP3wdNNrgGu66K2bZD9nR0O+wtfYK0OA+InU3MTnm SnS29Mrwp3hobXQwf1egLSkRvzOOAS2kWrl9xiO+v9WejXtxhO5TjQX6Qw3X8H0Hwp7sFdHrqDz0 eZmhFZxaa40DxZPJuLUk3zkVKd8pc5mP6beSNHbKMQV1UfbiBGigvJJVM+c6meDPAwDOcaqNje8q hOBKopqOfpulb5+Z1Eatid8jJQ2pO8R/nvIBV9x8Wn0ntE5UBXP3Eu109opdt9GERJVnCO6ammFZ 00AfyElvtk5NPfDFZk3jTGCd3X5p4tfRXn9GXx0PGKb8QzTgWquRH7dcifo50szgV0sWAwKUN9yk NNubfYqayNHTl3bwwp/fmUdK8LpTIOGqSEO8Ksk+aedMfNWSnJswrtlN5mGT48IFvi8WFE5K5/Lx QPd06DfnR9DSTZmJ9aFDVbfGe+vQJ+DtmAPBQudbD6qU3v6wZ7IoXpjh4mHbywmankhmyCZ8bKg2 Kc5++y0Lfc/onV+E7OMXRvgtdyMlnmWiNUc0RUij2DF5GQgTci8CG6vWoHRZ1XsdGinUDFhly7ZQ iMGR0zsxznk1FoD750QgiJx5/INrfYeCfChx7et3KLD+DX2GCwa/viUXfPjmCoh1VENkLvS/E7TF zuKMZQr5Pn/t1No6Uo/BSoX7P0owIlrBwFLkFu34pFQPdwPt57MJySdAVYFLa5JJDLBf3vXm92PN DpgLsd6Ddd/s7VM53nCKyp0xDX7jQvER7V6DofZpW12Huz6w/zdQ16XeR6X1agrMBT1LTRuWTYfP euLoRBrmn4zy813y6CiwpbCiWU+1DJwvBX7Ar+Z6tDDdkT492f6RGFgaY8lVVvNfDQgsT8PAknND OfM0S+MeGrcDlEkC3YblaMXi/C5RHIV/8jzOZrGGS0q9XHunX4Zup1uOQYX3u3klisnWcwJduLha ePKhJSQFILq+OB4oEw52dqT+sB9zVa3uQZKOroNj4FLASh5id//QafhsxeKTo/g+cADbsOhkH12s Y/x7N04LPZqYZNIARVagEMhjyGL5llQ69ynSZOFboHFezLLBHqQ89z8= X-Report-Abuse-To: spam@semaster01.mail.pcextreme.nl On 06/21/2018 05:13 PM, Daan Hoogland wrote: > Wido, I like the idea that we can generate from git what has happened since > last time. I also recognise that we don't do that properly all the time. True. But a bunch of commits don't akways tell the exact story. Well, they do, but not for the end-user. > What this comes down to is discipline, however we implement it. Deciding if > a change is big enough would be up to both the author and the reviewer and > we could ask for a comment tagged "Release Note:" as well. Just saying many > ways to do this. going with your idea from the ceph community. Where do we > move the release notes when the release is out? and when? (release > candidate/first thing after approval/part of the release commit) > You would move it to a file called "ReleaseNotes" afterwards, that is done by the Release Manager. Wido > On Wed, Jun 20, 2018 at 11:05 AM, Wido den Hollander wrote: > >> >> >> On 06/20/2018 07:53 AM, Rafael Weingärtner wrote: >>> It seems so. It can then be a part of the PR. I mean, in the PR we could >>> require a commit that updates this file. >> >> Yes, that would be the thing. When you send a PR with a change that is >> 'big enough' you also include updating the Pending Release Notes file. >> >>> Of course, we need to discuss if all PRs should update it, or only >>> important things should go in. >>> >> >> I think only important things and that it's up to the developer to guess >> if it's important enough to go into the PendingReleaseNotes file. >> >> Wido >> >>> +1 >>> >>> On Tue, Jun 19, 2018 at 11:00 PM, Wido den Hollander >> wrote: >>> >>>> Hi, >>>> >>>> At the Ceph project we work with a Pending Release Notes [0]. >>>> >>>> The idea is that if a developer writes a new feature or fixes something >>>> that changes functionality (or adds one) she/he also updates the >>>> PendingReleaseNotes file. >>>> >>>> That way when a new version is released it's easier for the Release >>>> Manager to know what to highlight. >>>> >>>> Although we can try to get everything from Jira and Github Issues it >>>> might be difficult to use the proper wording. >>>> >>>> On every release the files is cleared and people start to add again. >>>> >>>> Would this be something which could benefit CloudStack and make the >>>> release notes easier and more complete? >>>> >>>> Wido >>>> >>>> [0]: https://github.com/ceph/ceph/blob/master/PendingReleaseNotes >>>> >>> >>> >>> >> > > >