cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Khosrow Moossavi <kmooss...@cloudops.com>
Subject Potential backward incompatibility problem in building SystemVM
Date Fri, 16 Feb 2018 16:58:59 GMT
Hi

I just noticed that the changes [1] in tools/applince/build.sh may break
backward compatibility
of the building process of systemvmtremplate.

In the highlighted (and now removed) line, we used to have a predefined
name as "systemvm64template"
and if one still wants to execute "build.sh systemvm64template ..." (or any
other name they
want) the build will break (becauase of the now new if condition).

Was this intentional to always have a new "systemvmtemplate" as the name or
the new if
condition should be fixed? Super simple to fix anyway.

if [ "systemvmtemplate" != "${appliance_build_name}" ]; then

instead of:

if [ "${appliance}" != "${appliance_build_name}" ]; then


[1]
https://github.com/apache/cloudstack/commit/3839239a21fc14a64acc18900ae303961036ef91#diff-68ae31f5f30dae8f541e26b8acbd75eeL247

Khosrow Moossavi
CloudOps

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message