From dev-return-110466-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org Sat Jan 6 21:35:56 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 785F218062C for ; Sat, 6 Jan 2018 21:35:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 68170160C3B; Sat, 6 Jan 2018 20:35:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8834F160C19 for ; Sat, 6 Jan 2018 21:35:55 +0100 (CET) Received: (qmail 30547 invoked by uid 500); 6 Jan 2018 20:35:54 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 30532 invoked by uid 99); 6 Jan 2018 20:35:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Jan 2018 20:35:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6B2251A0483; Sat, 6 Jan 2018 20:35:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.011 X-Spam-Level: X-Spam-Status: No, score=-5.011 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=netapp.onmicrosoft.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id aGwg7IngeYoa; Sat, 6 Jan 2018 20:35:51 +0000 (UTC) Received: from mx143.netapp.com (mx143.netapp.com [216.240.21.24]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id EFA175F24A; Sat, 6 Jan 2018 20:35:50 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.46,323,1511856000"; d="scan'208";a="236446163" Received: from vmwexchts03-prd.hq.netapp.com ([10.122.105.31]) by mx143-out.netapp.com with ESMTP; 06 Jan 2018 12:35:44 -0800 Received: from VMWEXCCAS01-PRD.hq.netapp.com (10.122.105.11) by VMWEXCHTS03-PRD.hq.netapp.com (10.122.105.31) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Sat, 6 Jan 2018 12:35:44 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (10.120.60.153) by VMWEXCCAS01-PRD.hq.netapp.com (10.122.105.11) with Microsoft SMTP Server (TLS) id 15.0.1320.4 via Frontend Transport; Sat, 6 Jan 2018 12:35:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.onmicrosoft.com; s=selector1-netapp-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=h9RK+ocwHf66b2olBQA0CT2qzey2YqIhYT+KOfP7+VU=; b=l0R+xnIwDEflLKdatYkP7XTdXP8XVHul3vKGlPsgk8wL3agYtoi25ZV4URwo8P/+bzNNxnEDwnSNjgLfmojWYKrGeO3HGeqDrKfATGC2N1dl2VCjdSwpRx22h2vfjbnoIHp6oUZVp39qWC8Hkx1JbRX5lKzw/Uh+5RRyTLMen0U= Received: from MWHPR06MB2880.namprd06.prod.outlook.com (10.175.138.21) by MWHPR06MB2877.namprd06.prod.outlook.com (10.175.138.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Sat, 6 Jan 2018 20:35:42 +0000 Received: from MWHPR06MB2880.namprd06.prod.outlook.com ([10.175.138.21]) by MWHPR06MB2880.namprd06.prod.outlook.com ([10.175.138.21]) with mapi id 15.20.0386.006; Sat, 6 Jan 2018 20:35:42 +0000 From: "Tutkowski, Mike" To: "dev@cloudstack.apache.org" CC: "commits@cloudstack.apache.org" Subject: Re: [GitHub] DaanHoogland commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage Thread-Topic: [GitHub] DaanHoogland commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage Thread-Index: AQHThx6s68KWFzdvcUCsqUUkSVXLzqNnTZo+ Date: Sat, 6 Jan 2018 20:35:42 +0000 Message-ID: <75A3BE56-82A9-4077-8DC0-6DFE87C5EBE1@netapp.com> References: <151526439009.15227.13687559737566414365.gitbox@gitbox.apache.org> In-Reply-To: <151526439009.15227.13687559737566414365.gitbox@gitbox.apache.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Mike.Tutkowski@netapp.com; x-originating-ip: [2607:fb90:6cb5:8772:28a1:7a31:790:d665] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR06MB2877;6:ij95bUX7E3X+vU9tcGIC232uBIayXaZ2vZhjmzPyIYt9lEDCpCH28UlTopAqZU7r2XnINnh7BYB9R9MDSsTOGemv8bUEJQy0Z/EIgtGp/RZqfHDodecamb+eIGgdnJN1Xz4IOVZo9wzHLR51xbGiOMq8w8qSpK+u67AGxthPfXOMVFDJO9rPzM76v4Feyz9JZh3BS+v7iBVpz88DVtLKz0nQq89bF+xczFSa0Iy+YD0AL+KhdYnpjKOr9oPZPeJuormVn15DImx76SSNGIxn08Snao9doIyHHY/WiWHNDJbPYO31xXaHcqEWmZMcDZMb4892jMZ8rGTYw6ZwjFrKz8LVBXhe7WnMpiWAyE4TaSipC+wufQevYZUklRyJczSf;5:0CXYVhb+PGX6tFKb7kmc1FyixHlPKWOkTv19pCfgVoL9wOJUgcqviACUsqSvTcRxfN6CfGaZ6lRqIlEvVgFsvx7cdhNhw2kQGYO4fP3xYOXUC9IFWSBbBL8J77NRQHjJN13xFs7QeKkc8QXFRbUk64KtWAC62XNxT5AtkqMnF7A=;24:VAtVmknw4I4h2pgryKcHyMt/PobZgu6OL4JAESo5b0ExR6jBEbr50IdrqzWU4ejNYExFPDH3x0x5lzJoMQNQyneh7XPUMGjaUFRZyP4FoOc=;7:B0V2S+WTzFA+jT9uNb7gOGihC3zFYYQJdlMGomb21uwNWqtDZFRH4ggY/vkIsXZDs4xJqxtLcnVUVB49tp6KPq71wwvcLvPaBYzv4lrgFceT66TFuqcOjw78lYadBYPnNHjIVpNQ1kzQRThJpfzeEyg5kwr2nMJ+5S0ai6xSQVxausB5KUOt9MMYVK8s0OMqZxclZ01iU2OokE1Qvsb/jYWce/0+YHCLkJ7Y5rsmy0OqxWhf4oWqGZscm0bbxp95 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: e42c3db0-f158-443b-7518-08d555450e92 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MWHPR06MB2877; x-ms-traffictypediagnostic: MWHPR06MB2877: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041268)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:MWHPR06MB2877;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:MWHPR06MB2877; x-forefront-prvs: 0544D934E1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(396003)(39850400004)(346002)(376002)(39380400002)(59134003)(5383002)(189003)(199004)(24454002)(36756003)(59450400001)(8936002)(25786009)(106356001)(2900100001)(105586002)(966005)(102836004)(6246003)(5660300001)(97736004)(2351001)(82746002)(53546011)(6506007)(478600001)(2906002)(3280700002)(6116002)(76176011)(3660700001)(33656002)(4326008)(305945005)(229853002)(14454004)(2950100002)(6306002)(72206003)(6486002)(7736002)(1730700003)(86362001)(53936002)(81156014)(83716003)(316002)(77096006)(68736007)(6436002)(99286004)(8676002)(2501003)(6512007)(6916009)(450100002)(81166006)(5640700003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR06MB2877;H:MWHPR06MB2880.namprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: netapp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 9qGKLmnZKJn182G1Rtv+Oqe/0hvbnuFvedd+WIfRsmoZ/qbV0Ptz0rHVX7OaiVi19jF/wlnDxRWc0F3zSjaHlA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e42c3db0-f158-443b-7518-08d555450e92 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2018 20:35:42.5564 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR06MB2877 X-OriginatorOrg: netapp.com I know that the StorageSystemDataMotionStrategy class in particular is gett= ing a bit unwieldy. I plan to go through it after 4.11 to modularize and si= mplify it. Once we are good to go with our standard tests for this PR, I can re-run al= l managed-storage tests to make sure none of the modifications I put in per= reviewer comments broke anything. Thanks! > On Jan 6, 2018, at 11:46 AM, GitBox wrote: >=20 > DaanHoogland commented on issue #2298: CLOUDSTACK-9620: Enhancements for = managed storage > URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-35576693= 2 >=20 >=20 > @rhtyd if the tests come back alright I am alright with it but > @mike-tutkowski I plead that you have a look at simplifying the code an= d extract as much as possible into separate methods/helper classes on your = next iteration.=20 >=20 > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on GitHub and use the > URL above to go to the specific comment. >=20 > For queries about this service, please contact Infrastructure at: > users@infra.apache.org >=20 >=20 > With regards, > Apache Git Services