cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [DISCUSS] Freezing master for 4.11
Date Wed, 10 Jan 2018 17:20:22 GMT
I think that we agreed in th3 past that a blocker is either something that
prevents ACS to start or upgrade, or something that breaks prior
functionality.

On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander <wido@widodh.nl> wrote:

>
>
> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>
>> All,
>>
>>
>> I want to thank all the reviewers, contributors and PR authors for their
>> hard work, support and collaboration. We managed to review, test and merge
>> more than 100 PRs towards the 4.11 milestone!
>>
>>
>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>> recently added features:
>>
>> https://github.com/apache/cloudstack/milestone/3
>>
>>
>> To keep up with the release schedule, I think it's time we should focus
>> on stabilizing master, testing it, fix any regressions and blockers.
>>
>>
>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>> schedule and master will be open for PRs with following merge criteria:
>>
>> - Blocker fixes, especially those blocking the release
>>
>> - Test failure and regression fixes
>>
>> - Release related fixes for example - upgrade blockers, database path,
>> packaging and systemvmtemplate related etc.
>>
>>
>> Thoughts, objections?
>>
>>
> Awesome!
>
> I'm looking for the definition for a blocker, I recently found this one:
> https://github.com/apache/cloudstack/pull/2396
>
> For us this is a big problem as we keep running into it, but probably
> nobody else. I don't want to promote my own PR as a blocker, but what is
> the definition?
>
> Because it's my own PR I didn't add the 4.11 milestone.
>
> Looking forward to 4.11!
>
>
> Wido
>
>
>> - Rohit
>>
>> <https://cloudstack.apache.org>
>>
>>
>>
>> ________________________________
>> From: Khosrow Moossavi <kmoossavi@cloudops.com>
>> Sent: Monday, January 8, 2018 8:59:30 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>
>> +1 Daan and Rohit
>>
>> Khosrow Moossavi
>>
>> Cloud Infrastructure Developer
>>
>> t 514.447.3456
>>
>> <https://goo.gl/NYZ8KK>
>>
>>
>>
>> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
>> boris.stoyanov@shapeblue.com
>>
>>> wrote:
>>>
>>
>> Yes let’s do that.
>>>
>>>
>>> boris.stoyanov@shapeblue.com
>>> www.shapeblue.com<http://www.shapeblue.com>
>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>>
>>> rohit.yadav@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>> On 8 Jan 2018, at 14:41, Wido den Hollander <wido@widodh.nl> wrote:
>>>
>>>>
>>>>
>>>>
>>>> On 01/08/2018 01:30 PM, Rohit Yadav wrote:
>>>>
>>>>> All,
>>>>> Thank you everyone for your feedback. Given we're in agreement with
>>>>>
>>>> Daan's proposal, I'll summarize and add strategy:
>>>
>>>> - We'll freeze the 4.11 milestone to only these 9 PRs:
>>>>>
>>>> https://github.com/apache/cloudstack/milestone/3
>>>
>>>> - In addition, only blocker, test fixes, and release/packaging related
>>>>>
>>>> fixes may be accepted in master now.
>>>
>>>> - If we don't hear from authors within a day, the PRs may be removed
>>>>>
>>>> from the milestone.
>>>
>>>> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
>>>>> Does this look agreeable? Thanks.
>>>>>
>>>>
>>>> Yes, it does! When the first RC comes out we should be able to run
>>>>
>>> tests, fix what's broken and focus in the release and 4.12 afterwards.
>>>
>>>>
>>>> Wido
>>>>
>>>> - Rohit
>>>>> <https://cloudstack.apache.org>
>>>>> ________________________________
>>>>> From: Daan Hoogland <daan.hoogland@gmail.com>
>>>>> Sent: Monday, January 8, 2018 4:21:00 PM
>>>>> To: dev
>>>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>>> slow display of arrogance in reacting this time ; yeeaahhh
>>>>> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
>>>>> igor.voloshanenko@gmail.com> wrote:
>>>>>
>>>>>> You again faster than me )))
>>>>>>
>>>>>> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
>>>>>>
>>>>> igor.voloshanenko@gmail.com
>>>
>>>> :
>>>>>>>
>>>>>>
>>>>>> :D tnx )
>>>>>>> Updated by my colleague already
>>>>>>>
>>>>>>> 2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogland@gmail.com>:
>>>>>>>
>>>>>>> yeah, way ahead of you Igor ;) I asked a question about it
>>>>>>>>
>>>>>>>> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
>>>>>>>> igor.voloshanenko@gmail.com> wrote:
>>>>>>>>
>>>>>>>> Updates posted to https://github.com/apache/cloudstack/pull/2389
>>>>>>>>> Can you please review?
>>>>>>>>>
>>>>>>>>> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
>>>>>>>>>
>>>>>>>> igor.voloshanenko@gmail.com
>>>>>>>>
>>>>>>>>> :
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Sure. Got it.
>>>>>>>>>>
>>>>>>>>>> Will post update soon
>>>>>>>>>>
>>>>>>>>>> 2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogland@gmail.com
>>>>>>>>>>
>>>>>>>>> :
>>>>
>>>>>
>>>>>>>>>> Igor, I remember your PR and think it is fine. It
can also be
>>>>>>>>>>>
>>>>>>>>>> argued
>>>>>>
>>>>>>> that
>>>>>>>>>
>>>>>>>>>> it needs to go in as a security feature. For an RM
it is
>>>>>>>>>>>
>>>>>>>>>> unthinkably
>>>>>>
>>>>>>> late,
>>>>>>>>>
>>>>>>>>>> but fortunately it is very small. I will however
-1 it if it leads
>>>>>>>>>>>
>>>>>>>>>> to a
>>>>>>>>
>>>>>>>>> plethora of last minute PRs to include.
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko
Igor <
>>>>>>>>>>> igor.voloshanenko@gmail.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Guys, can we please include https://github.com/apache/clou
>>>>>>>>>>>>
>>>>>>>>>>> dstack/pull/2389
>>>>>>>>>>>
>>>>>>>>>>>> into 4.11
>>>>>>>>>>>> PR very small and updates will be published
in next few hours.
>>>>>>>>>>>>
>>>>>>>>>>>> As we have this for a while in production
for 4.8 branch.
>>>>>>>>>>>>
>>>>>>>>>>>> 2018-01-08 11:15 GMT+02:00 Boris Stoyanov
<
>>>>>>>>>>>>
>>>>>>>>>>> boris.stoyanov@shapeblue.com
>>>>>>>>>
>>>>>>>>>> :
>>>>>>>>>>>>
>>>>>>>>>>>> +1 Daan
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> boris.stoyanov@shapeblue.com
>>>>>>>>>>>>> www.shapeblue.com<http://www.shapeblue.com>
>>>>>>>>>>>>> 53 Chandos Place, Covent Garden, London
 WC2N 4HSUK
>>>>>>>>>>>>> @shapeblue
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 8 Jan 2018, at 10:47, Daan Hoogland
<
>>>>>>>>>>>>>>
>>>>>>>>>>>>> daan.hoogland@gmail.com>
>>>>>>>>
>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Rohit, Ivan,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I think we can argue that the five
open PRs on the milestone
>>>>>>>>>>>>>>
>>>>>>>>>>>>> can
>>>>>>>>
>>>>>>>>> still
>>>>>>>>>>>
>>>>>>>>>>>> go
>>>>>>>>>>>>
>>>>>>>>>>>>> in as long as active work on them continues.
I have not
>>>>>>>>>>>>>>
>>>>>>>>>>>>> looked
>>>>>>
>>>>>>> at
>>>>>>>>
>>>>>>>>> Ivan's
>>>>>>>>>>>>
>>>>>>>>>>>>> PRs yet but can see they were entered
in december and he is
>>>>>>>>>>>>>>
>>>>>>>>>>>>> actively
>>>>>>>>>
>>>>>>>>>> working on it so why not include those in the milestone.
A
>>>>>>>>>>>>>>
>>>>>>>>>>>>> bigger
>>>>>>>>
>>>>>>>>> concern
>>>>>>>>>>>>
>>>>>>>>>>>>> is that some of the remaining PRs in
that milestone are
>>>>>>>>>>>>>>
>>>>>>>>>>>>> potentially
>>>>>>>>>
>>>>>>>>>> conflicting. So we feature freeze now and work only
to get
>>>>>>>>>>>>>>
>>>>>>>>>>>>> the
>>>>>>
>>>>>>> set
>>>>>>>>
>>>>>>>>> list
>>>>>>>>>>>
>>>>>>>>>>>> in
>>>>>>>>>>>>>
>>>>>>>>>>>>>> (and blockers).
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Mon, Jan 8, 2018 at 9:39 AM, Ivan
Kudryavtsev <
>>>>>>>>>>>>>>
>>>>>>>>>>>>> kudryavtsev_ia@bw-sw.com>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Rohit, Devs,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> just consider adding:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> CLOUDSTACK-10188 / https://github.com/apache/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> cloudstack/pull/2362
>>>>>>>>>
>>>>>>>>>> [resouce
>>>>>>>>>>>>>
>>>>>>>>>>>>>> accounting blocker bug]
>>>>>>>>>>>>>>> CLOUDSTACK-10170 / https://github.com/apache/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> cloudstack/pull/2350
>>>>>>>>>
>>>>>>>>>> [security
>>>>>>>>>>>>>>> fix, enchancement]
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> They are ready (we think so)
for some time, but *no final
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> review*
>>>>>>>>
>>>>>>>>> yet.
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> 2018-01-08 14:47 GMT+07:00 Rohit
Yadav <
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> rohit.yadav@shapeblue.com
>>>>>>>>>
>>>>>>>>>> :
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>> All,
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> As per the previously shared
schedule [1], by EOD today (8
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Jan
>>>>>>>>
>>>>>>>>> 2018)
>>>>>>>>>>>
>>>>>>>>>>>> we
>>>>>>>>>>>>
>>>>>>>>>>>>> would freeze master after which we'll
only accept
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> critical/blocker
>>>>>>>>>
>>>>>>>>>> fixes,
>>>>>>>>>>>>>
>>>>>>>>>>>>>> stabilize master and start a voting
thread on 4.11 RC1
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> (est.
>>>>>>
>>>>>>> by
>>>>>>>>
>>>>>>>>> 15
>>>>>>>>>
>>>>>>>>>> Jan
>>>>>>>>>>>>
>>>>>>>>>>>>> 2018).
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I wanted to gather consensus
if this is acceptable to
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> everyone
>>>>>>>>
>>>>>>>>> as
>>>>>>>>>
>>>>>>>>>> there
>>>>>>>>>>>>
>>>>>>>>>>>>> are still few outstanding feature PRs
that I understand
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> authors
>>>>>>>>
>>>>>>>>> have
>>>>>>>>>>>
>>>>>>>>>>>> worked
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> hard to get them in.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Please share your thoughts,
comments.  If you're the author
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> of
>>>>>>>>
>>>>>>>>> such
>>>>>>>>>>>
>>>>>>>>>>>> an
>>>>>>>>>>>>
>>>>>>>>>>>>> existing PR, please work with us, address
outstanding
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> issues.
>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> In case of no objections,
it will be assumed that the plan
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> is
>>>>>>
>>>>>>> acceptable
>>>>>>>>>>>>>
>>>>>>>>>>>>>> to everyone. Thanks.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> [1] http://markmail.org/message/mszlluye35acvn2j
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> - Rohit
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> <https://cloudstack.apache.org>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> rohit.yadav@shapeblue.com
>>>>>>>>>>>>>>>> www.shapeblue.com<http://www.shapeblue.com>
>>>>>>>>>>>>>>>> 53 Chandos Place, Covent
Garden, London  WC2N 4HSUK
>>>>>>>>>>>>>>>> @shapeblue
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> With best regards, Ivan Kudryavtsev
>>>>>>>>>>>>>>> Bitworks Software, Ltd.
>>>>>>>>>>>>>>> Cell: +7-923-414-1515
>>>>>>>>>>>>>>> WWW: http://bitworks.software/
<http://bw-sw.com/>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Daan
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Daan
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Daan
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> --
>>>>> Daan
>>>>> rohit.yadav@shapeblue.com
>>>>> www.shapeblue.com<http://www.shapeblue.com>
>>>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>>>> @shapeblue
>>>>>
>>>>>
>>>
>>>
>>


-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message