cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tutkowski, Mike" <Mike.Tutkow...@netapp.com>
Subject Re: [GitHub] DaanHoogland commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
Date Sat, 06 Jan 2018 20:35:42 GMT
I know that the StorageSystemDataMotionStrategy class in particular is getting a bit unwieldy.
I plan to go through it after 4.11 to modularize and simplify it.

Once we are good to go with our standard tests for this PR, I can re-run all managed-storage
tests to make sure none of the modifications I put in per reviewer comments broke anything.

Thanks!

> On Jan 6, 2018, at 11:46 AM, GitBox <git@apache.org> wrote:
> 
> DaanHoogland commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
> URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355766932
> 
> 
>   @rhtyd if the tests come back alright I am alright with it but
>   @mike-tutkowski I plead that you have a look at simplifying the code and extract as
much as possible into separate methods/helper classes on your next iteration. 
> 
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
> 
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
> 
> 
> With regards,
> Apache Git Services

Mime
View raw message