Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
MIME-Version: 1.0
In-Reply-To: <VI1PR0701MB2944C8E339E9E6081DC98941E90C0@VI1PR0701MB2944.eurprd07.prod.outlook.com>
References: <CA+FPaebJvw_svORQGhMdCTky84DTtQdrS+nSzm763pGoSA3P0g@mail.gmail.com>
 <VI1PR0701MB2944C8E339E9E6081DC98941E90C0@VI1PR0701MB2944.eurprd07.prod.outlook.com>
From: =?UTF-8?Q?Rafael_Weing=C3=A4rtner?= <rafaelweingartner@gmail.com>
Date: Wed, 20 Dec 2017 10:36:46 -0200
Message-ID: <CAG97rafdvydtbymgkAdmpeL4igxZ0rTe0mw6hyR_oEUchj3VNw@mail.gmail.com>
Subject: Re: Adding Spellchecker to code style validator
To: dev@cloudstack.apache.org
Content-Type: multipart/alternative; boundary="001a113528202db4a00560c4d638"
archived-at: Wed, 20 Dec 2017 12:36:57 -0000

--001a113528202db4a00560c4d638
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

+1

On Wed, Dec 20, 2017 at 10:29 AM, Rohit Yadav <rohit.yadav@shapeblue.com>
wrote:

> Hi Ivan,
>
>
> Thanks for the PR, I think that would be a good idea. We can introduce
> such a checker/task in Travis's first job that currently does some sanity
> checks (rat+build+unit tests etc).
>
>
> - Rohit
>
> ________________________________
> From: Ivan Kudryavtsev <kudryavtsev_ia@bw-sw.com>
> Sent: Tuesday, December 19, 2017 12:48:04 PM
> To: dev
> Subject: Adding Spellchecker to code style validator
>
> Hello, devs.
>
> How about adding spell checking to code style guide. ACS uses a lot of ja=
va
> introspection including JSON generation, etc. so typos migrate to protoco=
l
> level. Working on CLOUDSTACK-10168 I found ipv4_adress inside python code=
 /
> dhcp related json, trying to improve "the camp" I moved to java code and
> found ipv4Adress private var which is used in gson serializer resulting t=
o
> the protocol with bad keywords. Might it be spellchecker is able to fix i=
t.
>
> The same thing is for logging messages, I usually looking for "address" n=
ot
> for "adress" so It's really impossible to find relevant message if typos
> exist.
>
> I'm not java guru to add spellchecker by myself and it's a project policy
> thing, so might be it's a thing which worth adoption?
>
>
> --
> With best regards, Ivan Kudryavtsev
> Bitworks Software, Ltd.
> Cell: +7-923-414-1515
> WWW: http://bitworks.software/ <http://bw-sw.com/>
>
> rohit.yadav@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


--=20
Rafael Weing=C3=A4rtner

--001a113528202db4a00560c4d638--