cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rafael Weingärtner <rafaelweingart...@gmail.com>
Subject Re: Using Maven wrapper
Date Wed, 15 Nov 2017 12:28:35 GMT
This seems to be interesting. Would you mind opening a PR?

On Tue, Nov 14, 2017 at 7:53 PM, Khosrow Moossavi <kmoossavi@cloudops.com>
wrote:

> No changes required in pom whatsover. Only the scripts/guides. For examaple
> in:
>
> /cloudstack/tools/travis/install.sh
> /cloudstack/deps/install-non-oss.sh
> /cloudstack/packaging/package.sh (even lines 63-69 will become useless)
> ...
>
> --
> Khosrow
>
>
>
> On Tue, Nov 14, 2017 at 4:33 PM, Rafael Weingärtner <
> rafaelweingartner@gmail.com> wrote:
>
> > This seems to be something interesting to be used. Do we need to make
> > changes to our pom.xml files to use it? Or is it only a matter of
> > protocol/guidelines?
> >
> > On Tue, Nov 14, 2017 at 7:06 PM, Khosrow Moossavi <
> kmoossavi@cloudops.com>
> > wrote:
> >
> > > Well basically anywhere (either manual or in scripts/CI) maven is
> > required
> > > to do something with ACS.
> > > Basically using *"./mvnw foo bar -Pbaz" *instead of *"mvn foo bar
> -Pbaz"*
> > > in which mvnw is an executable file in the repo not installed in the
> OS.
> > >
> > > Khosrow Moossavi
> > >
> > > Cloud Infrastructure Developer
> > >
> > > t 514.447.3456
> > >
> > > <https://goo.gl/NYZ8KK>
> > >
> > >
> > >
> > > On Tue, Nov 14, 2017 at 2:48 PM, Rafael Weingärtner <
> > > rafaelweingartner@gmail.com> wrote:
> > >
> > > > You mean, to use this tool to help us managing maven versions in ACS'
> > > > community distributed CIs and devs environments?
> > > >
> > > >
> > > > On Tue, Nov 14, 2017 at 5:15 PM, Khosrow Moossavi <
> > > kmoossavi@cloudops.com>
> > > > wrote:
> > > >
> > > > > Hi
> > > > >
> > > > > I'm new to ACS community, so I'm not sure if this topic has already
> > > come
> > > > up
> > > > > before.
> > > > >
> > > > > I wanted to suggest using Maven Wrapper (
> > > > > https://github.com/takari/maven-wrapper) and actually check it in
> in
> > > the
> > > > > repo rather than relying on existence of it on dev, ci, build,
> host,
> > > etc
> > > > > machine.
> > > > >
> > > > > With this we can get portability and consistency between builds.
> > > > >
> > > > > Regards
> > > > > ---
> > > > > Khosrow
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Rafael Weingärtner
> > > >
> > >
> >
> >
> >
> > --
> > Rafael Weingärtner
> >
>



-- 
Rafael Weingärtner

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message