cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Vazquez <Nicolas.Vazq...@shapeblue.com>
Subject Re: Clean up of unused constants
Date Tue, 26 Sep 2017 14:20:16 GMT
+1 too. Thanks Sigert

________________________________
From: Gabriel Beims Bräscher <gabrascher@gmail.com>
Sent: Tuesday, September 26, 2017 11:17:19 AM
To: dev@cloudstack.apache.org
Subject: Re: Clean up of unused constants

+1 on removing unused code.

2017-09-26 11:16 GMT-03:00 Marc-Aurèle Brothier <marco@exoscale.ch>:

> +1 to sort them too
>
> On Tue, Sep 26, 2017 at 4:13 PM, Daan Hoogland <
> daan.hoogland@shapeblue.com>
> wrote:
>
> > +1 Sigert, be my guest. We will run integration tests on your changes
> > anyway, so low risk ;)
> >
> > On 2017/09/26 15:55, "Rafael Weingärtner" <rafael@autonomiccs.com.br>
> > wrote:
> >
> >     IMO, if something is not used or if something does not work, it has
> to
> >     be removed or fixed.
> >
> >     I am +1 for the removal of unused constants. Did you check if the
> value
> >     of these unused constants were being used somewhere? I mean, using
> the
> >     value without referencing the constant.
> >
> >
> >     On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote:
> >     > Hi all,
> >     >
> >     > Am I allowed to remove all unused constants in ApiConstants.java?
> >     >
> >     > Kind regards,
> >     >
> >     > *Sigert Goeminne*
> >     > Software Development Engineer
> >     >
> >
> >     --
> >     Rafael Weingärtner
> >
> >
> >
> >
> > daan.hoogland@shapeblue.com
> > www.shapeblue.com<http://www.shapeblue.com>
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>

Nicolas.Vazquez@shapeblue.com 
www.shapeblue.com
,   
@shapeblue
  
 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message