Return-Path: <dev-return-108737-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 74839200C56
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 14 Apr 2017 14:41:55 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 7340F160B8C; Fri, 14 Apr 2017 12:41:55 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id E1D46160B80
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 14 Apr 2017 14:41:54 +0200 (CEST)
Received: (qmail 60077 invoked by uid 500); 14 Apr 2017 12:41:53 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 59811 invoked by uid 99); 14 Apr 2017 12:41:52 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Apr 2017 12:41:52 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 941BBDFB94; Fri, 14 Apr 2017 12:41:52 +0000 (UTC)
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-2046-cloudstack@git.apache.org>
In-Reply-To: <git-pr-2046-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...
Content-Type: text/plain
Message-Id: <20170414124152.941BBDFB94@git1-us-west.apache.org>
Date: Fri, 14 Apr 2017 12:41:52 +0000 (UTC)
archived-at: Fri, 14 Apr 2017 12:41:55 -0000

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/2046#discussion_r111568764
  
    --- Diff: api/src/org/apache/cloudstack/config/ApiServiceConfiguration.java ---
    @@ -28,6 +28,8 @@
                 "API end point. Can be used by CS components/services deployed remotely, for sending CS API requests", true);
         public static final ConfigKey<Long> DefaultUIPageSize = new ConfigKey<Long>("Advanced", Long.class, "default.ui.page.size", "20",
                 "The default pagesize to be used by UI and other clients when making list* API calls", true, ConfigKey.Scope.Global);
    +    public static final ConfigKey<String> ManagementAdminCidr = new ConfigKey<String>("Advanced", String.class, "management.admin.cidr",
    +            "0.0.0.0/0,::/0", "Comma separated list of IPv4/IPv6 CIDRs from which Admin accounts can perform API calls", true, ConfigKey.Scope.Global);
    --- End diff --
    
    argument for this default: backwards compatible
    argument against: inherent security risk


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---