Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1C356200C5C for ; Thu, 6 Apr 2017 07:12:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1ADF4160B9E; Thu, 6 Apr 2017 05:12:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5A4F0160B94 for ; Thu, 6 Apr 2017 07:12:23 +0200 (CEST) Received: (qmail 57979 invoked by uid 500); 6 Apr 2017 05:12:16 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 57968 invoked by uid 99); 6 Apr 2017 05:12:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Apr 2017 05:12:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 56498DFDAC; Thu, 6 Apr 2017 05:12:16 +0000 (UTC) From: jayapalu To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack issue #2018: CLOUDSTACK-9848: Added exit status checking for the ... Content-Type: text/plain Message-Id: <20170406051216.56498DFDAC@git1-us-west.apache.org> Date: Thu, 6 Apr 2017 05:12:16 +0000 (UTC) archived-at: Thu, 06 Apr 2017 05:12:24 -0000 Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/2018 @wido In the patch it can be observed that it is ("-A FIREWALL_%s DROP" % ) running without '-j' and it is not caught. There is duplicate rule due this the impact is not seen. So I have added the checking the iptables add command exit status, with this iptables add command failure are caught. If there is error or exception then it error will be returned to management server. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---