cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...
Date Fri, 14 Apr 2017 15:31:08 GMT
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/2046#discussion_r111589627
  
    --- Diff: api/src/org/apache/cloudstack/config/ApiServiceConfiguration.java ---
    @@ -28,6 +28,8 @@
                 "API end point. Can be used by CS components/services deployed remotely,
for sending CS API requests", true);
         public static final ConfigKey<Long> DefaultUIPageSize = new ConfigKey<Long>("Advanced",
Long.class, "default.ui.page.size", "20",
                 "The default pagesize to be used by UI and other clients when making list*
API calls", true, ConfigKey.Scope.Global);
    +    public static final ConfigKey<String> ManagementAdminCidr = new ConfigKey<String>("Advanced",
String.class, "management.admin.cidr",
    +            "0.0.0.0/0,::/0", "Comma separated list of IPv4/IPv6 CIDRs from which Admin
accounts can perform API calls", true, ConfigKey.Scope.Global);
    --- End diff --
    
    I agree. I have set it to open for all for now. We can submit a different PR afterwards
to change the default imho.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message