cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...
Date Fri, 14 Apr 2017 12:38:12 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/2046#discussion_r111568225
  
    --- Diff: core/src/com/cloud/network/HAProxyConfigurator.java ---
    @@ -538,7 +536,7 @@ private String getLbSubRuleForStickiness(final LoadBalancerTO lbTO)
{
             if (stickinessSubRule != null && !destsAvailable) {
                 s_logger.warn("Haproxy stickiness policy for lb rule: " + lbTO.getSrcIp()
+ ":" + lbTO.getSrcPort() + ": Not Applied, cause:  backends are unavailable");
             }
    -        if (publicPort.equals(NetUtils.HTTP_PORT) && !keepAliveEnabled || httpbasedStickiness)
{
    +        if (publicPort == NetUtils.HTTP_PORT && !keepAliveEnabled || httpbasedStickiness)
{
    --- End diff --
    
    why this? equals() seems more what is intended then ==
    is making it an int really the best? as opposed to Integer (or String for that matter)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message