cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...
Date Thu, 06 Apr 2017 07:17:47 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1282#discussion_r110092478
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
    @@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
                 return true;
             }
     
    +        if(snapshotVO.getState() == Snapshot.State.Allocated) {
    --- End diff --
    
    @anshul1886 the code to check and remove snapshot when they are stuck in Allocated state
is already in line 223 above, in the same method. Why this redundancy, is this a synchronization
issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message