cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...
Date Tue, 04 Apr 2017 16:06:35 GMT
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1935#discussion_r102538324
  
    --- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
    @@ -109,6 +112,20 @@
         @Inject
         MessageBus _messageBus;
     
    +    static boolean rollBackState = false;
    --- End diff --
    
    @nvazquez I have been thinking about this variable you introduced here. I think it can
cause problems (concurrency problems). The `DomainManagerImpl` is a singleton. Therefore,
it should not have state variables. The `rollBackState ` is acting as a state variable for
requests that use `com.cloud.user.DomainManagerImpl.deleteDomain(DomainVO, Boolean)`. The
problem is that every call should have its own context/state for `rollBackState`. However,
this will not happen with the current implementation.
    
    I think we should re-work the use of that variable. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message