cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Stor...
Date Sun, 02 Apr 2017 02:57:45 GMT
Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/876#discussion_r109299000
  
    --- Diff: plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
---
    @@ -359,7 +359,7 @@ public boolean attachCluster(DataStore store, ClusterScope scope)
{
     
             PrimaryDataStoreInfo primarystore = (PrimaryDataStoreInfo) store;
             // Check if there is host up in this cluster
    -        List<HostVO> allHosts = _resourceMgr.listAllUpAndEnabledHosts(Host.Type.Routing,
primarystore.getClusterId(), primarystore.getPodId(), primarystore.getDataCenterId());
    +        List<HostVO> allHosts = _resourceMgr.listAllUpHosts(Host.Type.Routing,
primarystore.getClusterId(), primarystore.getPodId(), primarystore.getDataCenterId());
    --- End diff --
    
    What about hosts which are in maintenance? Do we expect to add an SR to those hosts as
well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message