Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: koushik-das <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1867-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1867-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Content-Type: text/plain
Message-Id: <20170315110035.E7E5FE029E@git1-us-west.apache.org>
Date: Wed, 15 Mar 2017 11:00:35 +0000 (UTC)
archived-at: Wed, 15 Mar 2017 11:00:39 -0000

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1867#discussion_r106137098
  
    --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
    @@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring) {
                             }
                         }
     
    +                    //destroy snapshots in destroying state in snapshot_store_ref
    +                    List<SnapshotDataStoreVO>  ssSnapshots = _snapshotStoreDao.listByState(ObjectInDataStoreStateMachine.State.Destroying);
    +                    for(SnapshotDataStoreVO ssSnapshotVO : ssSnapshots){
    +                        try {
    +                            _snapshotService.deleteSnapshot(snapshotFactory.getSnapshot(ssSnapshotVO.getSnapshotId(), DataStoreRole.Image));
    --- End diff --
    
    deleteSnapshot() is going to send an agent command to cleanup the snapshot from secondary, if there is any failure will cleanup be retried or the DB entry is simply updated?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---