Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: yvsubhash <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1987-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1987-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain...
Content-Type: text/plain
Message-Id: <20170303120240.5C1A8DFC15@git1-us-west.apache.org>
Date: Fri,  3 Mar 2017 12:02:40 +0000 (UTC)
archived-at: Fri, 03 Mar 2017 12:02:43 -0000

Github user yvsubhash commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1987#discussion_r104140435
  
    --- Diff: server/src/org/apache/cloudstack/region/RegionManagerImpl.java ---
    @@ -229,7 +232,7 @@ public boolean deleteUser(DeleteUserCmd cmd) {
          */
         @Override
         public Domain updateDomain(UpdateDomainCmd cmd) {
    -        return _domainMgr.updateDomain(cmd);
    +        return _managementService.updateDomain(cmd);
    --- End diff --
    
    Instead of changing the method that is getting called, the missing one in search query can be added here and it seems the updateDomain method in managementserviceimpl is not in use. It can be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---