Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: priyankparihar <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1894-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1894-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...
Content-Type: text/plain
Message-Id: <20170303091525.58585DFDE6@git1-us-west.apache.org>
Date: Fri,  3 Mar 2017 09:15:25 +0000 (UTC)
archived-at: Fri, 03 Mar 2017 09:15:27 -0000

Github user priyankparihar commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1894#discussion_r104114043
  
    --- Diff: api/src/org/apache/cloudstack/api/command/user/template/CopyTemplateCmd.java ---
    @@ -51,25 +52,46 @@
         @Parameter(name = ApiConstants.DESTINATION_ZONE_ID,
                    type = CommandType.UUID,
                    entityType = ZoneResponse.class,
    -               required = true,
    +               required = false,
                    description = "ID of the zone the template is being copied to.")
    -    private Long destZoneId;
    +    protected Long destZoneId;
     
    -    @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = TemplateResponse.class, required = true, description = "Template ID.")
    +    @Parameter(name = ApiConstants.ID, type = CommandType.UUID,
    +            entityType = TemplateResponse.class, required = true, description = "Template ID.")
         private Long id;
     
         @Parameter(name = ApiConstants.SOURCE_ZONE_ID,
                    type = CommandType.UUID,
                    entityType = ZoneResponse.class,
    -            description = "ID of the zone the template is currently hosted on. If not specified and template is cross-zone, then we will sync this template to region wide image store.")
    +            description = "ID of the zone the template is currently hosted on. " +
    +                    "If not specified and template is cross-zone, " +
    +                    "then we will sync this template to region wide image store.")
    --- End diff --
    
    This change is not required. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---