Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CFD20200C2B for ; Thu, 2 Mar 2017 11:36:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CE599160B6F; Thu, 2 Mar 2017 10:36:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1DAC2160B61 for ; Thu, 2 Mar 2017 11:36:10 +0100 (CET) Received: (qmail 5806 invoked by uid 500); 2 Mar 2017 10:36:10 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 5792 invoked by uid 99); 2 Mar 2017 10:36:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 10:36:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D690ADFCA1; Thu, 2 Mar 2017 10:36:09 +0000 (UTC) From: prashanthvarma To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack issue #1981: CLOUDSTACK-9806: Nuage domain template selection per... Content-Type: text/plain Message-Id: <20170302103609.D690ADFCA1@git1-us-west.apache.org> Date: Thu, 2 Mar 2017 10:36:09 +0000 (UTC) archived-at: Thu, 02 Mar 2017 10:36:12 -0000 Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack/pull/1981 @borisstoyanov I am glad you liked the PR, we (@nuagenetworks) made it a practice to add and run integration tests that test the changes we propose/make in a PR. Moreover, we internally qualify through regressions the whole system with those changes for both Nuage VSP and native ACS setups/environments where necessary. Thank you for kicking the regression tests. Please do also code review the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---