cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1810: CLOUDSTACK-9647: NIC adapter type becomes e10...
Date Fri, 31 Mar 2017 14:47:45 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1810#discussion_r109176660
  
    --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
    @@ -280,6 +286,16 @@ public boolean finalizeVirtualMachineProfile(final VirtualMachineProfile
profile
         public boolean finalizeCommandsOnStart(final Commands cmds, final VirtualMachineProfile
profile) {
             final DomainRouterVO domainRouterVO = _routerDao.findById(profile.getId());
     
    +        Map<String, String> details = new HashMap<String, String>();
    +
    +        if(profile.getHypervisorType() == Hypervisor.HypervisorType.VMware){
    +            HypervisorGuru hvGuru = _hvGuruMgr.getGuru(profile.getHypervisorType());
    +            VirtualMachineTO vmTO = hvGuru.implement(profile);
    +            if(vmTO.getDetails() != null){
    +                details = vmTO.getDetails();
    --- End diff --
    
    Otherwise LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message