cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloudsadhu <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Date Mon, 27 Mar 2017 05:21:32 GMT
Github user cloudsadhu commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1813#discussion_r108092328
  
    --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py ---
    @@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self):
             # 2. root disk has new size per listVolumes
             # 3. Rejects non-supported hypervisor types
             """
    -        if(self.hypervisor.lower() == 'kvm'):
    +        full_clone_config = Configurations.list(self.apiclient,
    +                            name="vmware.create.full.clone")[0].value
    +        if full_clone_config == 'false' and self.hypervisor.lower() == 'vmware':
    +            self.skipTest("root disk resize is not supported "+
    +                "when vmware.create.full.clone is %s" % full_clone_config)
    +
    --- End diff --
    
    I have incorporated the review comments (added full clone logic as well  fine tuned the
code) in test_deploy_vm_resize.py script.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message