cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack
Date Tue, 21 Mar 2017 09:59:01 GMT
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1859
  
    At least since August 2015, we've been following the guideline [1][2] for 2LGTMs and to
squash changes when they are accepted. AFAIK RMs for 4.6+ have been asking PR authors to squash
their changes before merging the PR once their PR is accepted, the consensus has been followed
and enforced.
    
    I've only requested the PR authors to follow what has been followed in the community/PRs
for a very long time, however I encourage any disagreements to be debated on dev ML than be
discussed and burried in a pull request as this affects everyone. /cc @karuturi 
    
    As an individual contributor, I prefer squashing changes for a single feature/FR into
one or fewer commits. Sometimes, it may make sense to squash changes to more than one commit
though 90 seems like an outrageous number. If multiple authors have worked on the PR, authors
can consider squashing changes to lowest possible grouped/squashed changes. Lastly, we've
also seen several feature PRs with several kloc+ changes that were accepted as a single squashed
commit that may be searched through Github PR search page.
    
    [1] http://markmail.org/thread/4cvxhm67ef356ppu
    [2] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message