cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack
Date Tue, 21 Mar 2017 06:37:41 GMT
Github user karuturi commented on the issue:

    https://github.com/apache/cloudstack/pull/1859
  
    When debugging, I have seen issues with humongous commits with little or no history. They
are very difficult to understand.
    This is a feature and it need not be backported. so, backporting to previous releases
is out of question. up-porting automatically happens.
    If we want to revert the feature, we revert the merge which is very easy to do.
    Also, reverting (for feature stability reasons) is just temporary. 
    I agree that the number of commits is high. But, the amount of code is also high and from
different authors who wants to keep it this way.
    I am +1 with keeping it as is. 
    I prefer merges with proper history and small logical units.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message