cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request #2009: CLOUDSTACK-9369 Fixed Ldap regression
Date Mon, 20 Mar 2017 09:09:06 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/2009#discussion_r106854397
  
    --- Diff: server/src/com/cloud/api/auth/DefaultLoginAPIAuthenticatorCmd.java ---
    @@ -166,7 +166,7 @@ public String authenticate(String command, Map<String, Object[]>
params, HttpSes
                         throw new CloudAuthenticationException("Unable to find the domain
from the path " + domain);
                     }
                     final UserAccount userAccount = _accountService.getActiveUserAccount(username[0],
domainId);
    -                if (userAccount == null || !(User.Source.UNKNOWN.equals(userAccount.getSource())
|| User.Source.LDAP.equals(userAccount.getSource()))) {
    +                if (userAccount != null && User.Source.SAML2 == userAccount.getSource())
{
    --- End diff --
    
    in case of LDAP, account will be created if it doesnt already exist.
    https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP%3A+Trust+AD+and+Auto+Import


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message